From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH 6/6] libstdc++: Import MSVC floating-point std::from_chars testcases
Date: Mon, 17 Jan 2022 10:54:17 +0000 [thread overview]
Message-ID: <CACb0b4=iL0VBTWX_4tok0QL2mHKuOJRzu9TVzZn0PYu_JigZzQ@mail.gmail.com> (raw)
In-Reply-To: <20220116180652.3694791-6-ppalka@redhat.com>
On Sun, 16 Jan 2022 at 18:17, Patrick Palka via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:
> libstdc++-v3/ChangeLog:
>
> * testsuite/20_util/from_chars/double.cc: New test, consisting
> of testcases extracted from the MSVC STL testsuite.
> * testsuite/20_util/from_chars/float.cc: New test.
> ---
> .../testsuite/20_util/from_chars/double.cc | 1674 +++++++++++++++++
> .../testsuite/20_util/from_chars/float.cc | 290 +++
> 2 files changed, 1964 insertions(+)
> create mode 100644 libstdc++-v3/testsuite/20_util/from_chars/double.cc
> create mode 100644 libstdc++-v3/testsuite/20_util/from_chars/float.cc
>
> diff --git a/libstdc++-v3/testsuite/20_util/from_chars/double.cc
> b/libstdc++-v3/testsuite/20_util/from_chars/double.cc
> new file mode 100644
> index 00000000000..ce53a1c56c2
> --- /dev/null
> +++ b/libstdc++-v3/testsuite/20_util/from_chars/double.cc
> @@ -0,0 +1,1674 @@
> +// This file consists of testcases extracted from the MSVC STL testsuite.
> +
> +// Copyright (c) Microsoft Corporation.
> +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
>
I think we should probably move (or copy) the
libstdc++-v3/include/pstl/LICENSE.txt file to another directory, since we
have files using this licence in other places too.
Please hold off committing this one while I think about that (and remind me
if you don't hear back from me with a decision).
next prev parent reply other threads:[~2022-01-17 10:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 18:06 [PATCH 1/6 v2] libstdc++: Directly implement hexfloat std::from_chars for binary32/64 Patrick Palka
2022-01-16 18:06 ` [PATCH 2/6] libstdc++: Import the fast_float library Patrick Palka
2022-01-17 10:45 ` Jonathan Wakely
2022-01-18 3:10 ` Hans-Peter Nilsson
2022-01-16 18:06 ` [PATCH 3/6] libstdc++: Apply modifications to our local copy of fast_float Patrick Palka
2022-01-17 10:46 ` Jonathan Wakely
2022-01-16 18:06 ` [PATCH 4/6] libstdc++: Adjust fast_float's over/underflow behavior for conformnace Patrick Palka
2022-01-17 10:49 ` Jonathan Wakely
2022-01-17 20:05 ` Patrick Palka
2022-01-16 18:06 ` [PATCH 5/6] libstdc++: Use fast_float in std::from_chars for binary32/64 Patrick Palka
2022-01-17 10:50 ` Jonathan Wakely
2022-01-16 18:06 ` [PATCH 6/6] libstdc++: Import MSVC floating-point std::from_chars testcases Patrick Palka
2022-01-17 10:54 ` Jonathan Wakely [this message]
2022-01-17 20:23 ` Patrick Palka
2022-01-17 10:34 ` [PATCH 1/6 v2] libstdc++: Directly implement hexfloat std::from_chars for binary32/64 Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=iL0VBTWX_4tok0QL2mHKuOJRzu9TVzZn0PYu_JigZzQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).