From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH 2/6] libstdc++: Import the fast_float library
Date: Mon, 17 Jan 2022 10:45:29 +0000 [thread overview]
Message-ID: <CACb0b4kbcAVKRyqYmVin3HXB7Zp+G9e0S-oRojfd99p5dTbb5A@mail.gmail.com> (raw)
In-Reply-To: <20220116180652.3694791-2-ppalka@redhat.com>
On Sun, 16 Jan 2022 at 18:13, Patrick Palka via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:
> We're going to use the fast_float library in our (compiled-in)
> floating-point std::from_chars implementation for faster and more
> portable parsing of binary32/64 decimal strings.
>
> The single file fast_float.h is an amalgamation of the entire library,
> which can be (re)generated with the command
>
> python3 ./script/amalgamate.py --license=MIT \
> > $GCC_SRC/libstdc++-v3/c++17/fast_float/fast_float.h
>
Please mention that the script is in the fast_float repo (so people don't
look for it in our repo).
Please mention in the commit log that the code has a GPL-compatible licence.
>
> [1]: https://github.com/fastfloat/fast_float
>
> libstdc++-v3/ChangeLog:
>
> * src/c++17/fast_float/LOCAL_PATCHES: New file.
> * src/c++17/fast_float/MERGE: New file.
> * src/c++17/fast_float/README.fd: New file, copied from the
> fast_float library sources.
> * src/c++17/fast_float/fast_float.h: New file, an amalgamation
> of the fast_float library.
>
> Signed-off-by: Patrick Palka <ppalka@redhat.com>
>
This project is great. The licence is compatible, and the licence text and
copyright notices are preserved in the code being imported. The entire
license text is present in the header, so there is no need for a separate
licence file.
The symbols that will be added to libstdc++ are not uglified, but the
header is included inside an unnamed namespace, so we will not define any
non-reserved symbols in libstdc++.a (and they aren't exported from
libstdc++.so anyway).
OK for trunk.
next prev parent reply other threads:[~2022-01-17 10:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 18:06 [PATCH 1/6 v2] libstdc++: Directly implement hexfloat std::from_chars for binary32/64 Patrick Palka
2022-01-16 18:06 ` [PATCH 2/6] libstdc++: Import the fast_float library Patrick Palka
2022-01-17 10:45 ` Jonathan Wakely [this message]
2022-01-18 3:10 ` Hans-Peter Nilsson
2022-01-16 18:06 ` [PATCH 3/6] libstdc++: Apply modifications to our local copy of fast_float Patrick Palka
2022-01-17 10:46 ` Jonathan Wakely
2022-01-16 18:06 ` [PATCH 4/6] libstdc++: Adjust fast_float's over/underflow behavior for conformnace Patrick Palka
2022-01-17 10:49 ` Jonathan Wakely
2022-01-17 20:05 ` Patrick Palka
2022-01-16 18:06 ` [PATCH 5/6] libstdc++: Use fast_float in std::from_chars for binary32/64 Patrick Palka
2022-01-17 10:50 ` Jonathan Wakely
2022-01-16 18:06 ` [PATCH 6/6] libstdc++: Import MSVC floating-point std::from_chars testcases Patrick Palka
2022-01-17 10:54 ` Jonathan Wakely
2022-01-17 20:23 ` Patrick Palka
2022-01-17 10:34 ` [PATCH 1/6 v2] libstdc++: Directly implement hexfloat std::from_chars for binary32/64 Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4kbcAVKRyqYmVin3HXB7Zp+G9e0S-oRojfd99p5dTbb5A@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).