From: Jonathan Wakely <jwakely@redhat.com>
To: Thomas Rodgers <trodgers@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Add missing free functions for atomic_flag [PR103934]
Date: Wed, 2 Feb 2022 21:35:29 +0000 [thread overview]
Message-ID: <CACb0b4=yv-v=bt3JB=JL+NTNnprN6uXZqn2XHutiL-Wx5kPkKA@mail.gmail.com> (raw)
In-Reply-To: <CAMmuTO-PCj=F4QR8c3zoa9zW+CqLVYXG=JxT_ssYbaL+rzj+RQ@mail.gmail.com>
>+ inline void
>+ atomic_flag_wait_explicit(const atomic_flag* __a, bool __old,
>+ std::memory_order __m) noexcept
No need for the std:: qualification, and check the indentation.
> libstdc++-v3/ChangeLog:
>
> PR103934
This needs to include the component: PR libstdc++/103934
> * include/std/atomic: Add missing free functions.
Please name the new functions in the changelog, in the usual format.
Just the names is fine, no need for the full signatures with
parameters.
OK for trunk with those changes.
next prev parent reply other threads:[~2022-02-02 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 2:53 Thomas Rodgers
2022-02-02 21:35 ` Jonathan Wakely [this message]
2023-02-10 18:25 ` Thomas Rodgers
2023-02-11 0:41 ` Jonathan Wakely
2023-02-14 2:06 ` Thomas Rodgers
2023-03-10 2:39 ` Thomas Rodgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=yv-v=bt3JB=JL+NTNnprN6uXZqn2XHutiL-Wx5kPkKA@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=trodgers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).