From: Jonathan Wakely <jwakely@redhat.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
"libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] libstdc++: Enable string_view in freestanding
Date: Fri, 13 Jan 2023 14:17:09 +0000 [thread overview]
Message-ID: <CACb0b4kGtMOZnxbmONbZEgzchknVi6wF7CX9t46RAPBrHCUbUg@mail.gmail.com> (raw)
In-Reply-To: <86mt6q4ajt.fsf@aarsen.me>
On Tue, 10 Jan 2023 at 16:31, Arsen Arsenović via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> Hi Jonathan,
>
> Jonathan Wakely <jwakely.gcc@gmail.com> writes:
>
> > Sorry for the top post.
> >
> > -#define __cpp_lib_string_contains 202011L
> > +#if _GLIBCXX_HOSTED
> > + // This FTM is not hosted as it also implies matching <string>
> > support,
> > + // and <string> is omitted from the freestanding subset.
> > +# define __cpp_lib_string_contains 202011L
> > +#endif // HOSTED
> >
> > That should say "not freestanding", right?
>
> Whoops, yes. Here's the fixed-up patch.
Tested powerpc64le-linux and pushed to trunk, thanks!
prev parent reply other threads:[~2023-01-13 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 10:03 Arsen Arsenović
2023-01-10 10:03 ` [PATCH 2/2] libstdc++: Fix a few !HOSTED test regressions Arsen Arsenović
2023-01-13 14:17 ` Jonathan Wakely
2023-01-10 14:26 ` [PATCH 1/2] libstdc++: Enable string_view in freestanding Jonathan Wakely
2023-01-10 16:19 ` Arsen Arsenović
2023-01-13 14:17 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4kGtMOZnxbmONbZEgzchknVi6wF7CX9t46RAPBrHCUbUg@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).