From: Jonathan Wakely <jwakely@redhat.com>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Reuse double overload of __convert_to_v if possible
Date: Fri, 18 Aug 2023 00:30:14 +0100 [thread overview]
Message-ID: <CACb0b4kU4Bto4X7DdxzL0QNBVR_-H7d9aY_RVgLtvsexnoUaaA@mail.gmail.com> (raw)
In-Reply-To: <20230817231932.EEB372041D@pchp3.se.axis.com>
On Fri, 18 Aug 2023 at 00:20, Hans-Peter Nilsson <hp@axis.com> wrote:
>
> > Date: Thu, 17 Aug 2023 21:32:29 +0100
> > From: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>
>
> > Tested x86_64-linux. Pushed to trunk.
>
> Does the below typo imply that for x86_64-linux,
> "__DBL_MANT_DIG__ == __LDBL_MANT_DIG__" is false and the
> code is actually untested?
Yes, but I thought I'd tested it on a suitable cross-compiler last week.
I've reverted it for now (at r14-3310-gb860e657802b96) and will retest
next week.
>
> > libstdc++-v3/ChangeLog:
> >
> > * config/locale/generic/c_locale.cc (__convert_to_v): Reuse
> > double overload for long double if possible.
>
> Breakage for cris-elf:
>
> libtool: compile: /auto/cris-elf/gccobj/./gcc/xgcc -shared-libgcc -B/auto/cris-elf/gccobj/./gcc -nostdinc++ -L/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/src -L/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/src/.libs -L/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/libsupc++/.libs -nostdinc -B/auto/cris-elf/gccobj/cris-elf/newlib/ -isystem /auto/cris-elf/gccobj/cris-elf/newlib/targ-include -isystem /auto/gcc/newlib/libc/include -B/auto/cris-elf/gccobj/cris-elf/libgloss/cris -L/auto/cris-elf/gccobj/cris-elf/libgloss/libnosys -L/auto/gcc/libgloss/cris -B/auto/cris-elf/pre/cris-elf/bin/ -B/auto/cris-elf/pre/cris-elf/lib/ -isystem /auto/cris-elf/pre/cris-elf/include -isystem /auto/cris-elf/pre/cris-elf/sys-include -I/auto/gcc/libstdc++-v3/../libgcc -I/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/include/cris-elf -I/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/include -I/auto/gcc/libstdc++-v3/libsupc++ -std=gnu++98 -fno-implicit-templates -Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi=2 -fdiagnos
> tics-show-location=once -ffunction-sections -fdata-sections -frandom-seed=c++locale.lo -g -O2 -fimplicit-templates -c c++locale.cc -o c++locale.o
> c++locale.cc: In function 'void std::__convert_to_v(const char*, _Tp&, ios_base::iostate&, int* const&) [with _Tp = long double; ios_base::iostate = ios_base::iostate; __c_locale = int*]':
> c++locale.cc:192:49: error: expected primary-expression before ')' token
> 192 | __convert_to_v(__s, __d, __err, __c_locale);
> | ^
> make[5]: *** [Makefile:881: c++locale.lo] Error 1
> make[5]: Leaving directory '/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/src/c++98'
>
> (Formally, a commit in the range ee40bdbfb07c..aad83d61d2e9
> but this one seems pretty clear.)
>
> In the context:
> __convert_to_v(const char* __s, long double& __v,
> ios_base::iostate& __err, const __c_locale&) throw()
>
> So, __c_locale" appears to be the type(def) and you're
> missing a parameter name. :)
>
> brgds, H-P
>
prev parent reply other threads:[~2023-08-17 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 20:32 Jonathan Wakely
2023-08-17 23:19 ` Hans-Peter Nilsson
2023-08-17 23:30 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4kU4Bto4X7DdxzL0QNBVR_-H7d9aY_RVgLtvsexnoUaaA@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).