From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "Björn Schäpers" <gcc@hazardy.de>,
gcc-patches@gc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Add error handler for <stacktrace>
Date: Wed, 30 Nov 2022 11:57:06 +0000 [thread overview]
Message-ID: <CACb0b4kWc8izwDr_H6iCq1cJLwAr+d9ViwVnpYFy=s6rkiP55g@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4nR8Rx9=vpaTh48EkrL+osj8o7FTaBchPW8AUaQVxf0SA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely <jwakely@redhat.com> wrote:
>
>
> On Wed, 30 Nov 2022 at 06:04, François Dumont via Libstdc++ <
> libstdc++@gcc.gnu.org> wrote:
>
>> Good catch, then we also need this patch.
>>
>
> Is it worth printing an error? If we can't show the backtrace because of
> an error, we can just print nothing there.
>
> We also need to pass an error handler to the
> __glibcxx_backtrace_create_state call in formatter.h.
>
> Now that I look at this code again, why do we need the _M_backtrace_full
> member? It's always set to the same thing, why can't we just call that
> function directly?
>
Oh right, I remember now ... because otherwise the libstdc++.so library
needs the definition of __glibcxx_backtrace_full.
> And I think we should use threaded=1 for the
> __glibcxx_backtrace_create_state call.
>
> So like the attached patch.
>
>
>
next prev parent reply other threads:[~2022-11-30 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 21:41 Björn Schäpers
2022-11-30 6:04 ` François Dumont
2022-11-30 11:54 ` Jonathan Wakely
2022-11-30 11:57 ` Jonathan Wakely [this message]
2022-11-30 13:07 ` Jonathan Wakely
2022-11-30 18:00 ` François Dumont
2022-12-06 21:44 ` Jonathan Wakely
2022-12-07 17:58 ` François Dumont
2022-12-07 20:06 ` Jonathan Wakely
2022-11-30 18:17 ` François Dumont
2022-11-30 19:20 ` Björn Schäpers
2022-11-30 12:31 ` Jonathan Wakely
2022-11-30 13:05 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4kWc8izwDr_H6iCq1cJLwAr+d9ViwVnpYFy=s6rkiP55g@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gc.gnu.org \
--cc=gcc@hazardy.de \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).