public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Matthias Kretz <m.kretz@gsi.de>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH 6/8] libstdc++: Fix formatting
Date: Fri, 24 Feb 2023 17:14:53 +0000	[thread overview]
Message-ID: <CACb0b4kcarNm2RrM4CYrOfdBuyTJC+2G+d9UPiR8mfihnrNVKA@mail.gmail.com> (raw)
In-Reply-To: <2147606.Icojqenx9y@minbar>

On Thu, 23 Feb 2023 at 08:54, Matthias Kretz via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
>
>
> Whitespace changes only.

Looks like there are a few remaining spaces that could be removed
where you've joined lines, e.g.

+    { return static_cast<_Up*>( __builtin_assume_aligned(__ptr,
_S_alignment<_Tp, _Up>)); }

and

+  { return __vector_type_t<_Tp, _Np>{
static_cast<_Tp>(__gen(_SizeConstant<_I>()))...}; }

OK for trunk anyway (and the branches if you want).


>
> Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
>
> libstdc++-v3/ChangeLog:
>
>         * include/experimental/bits/simd.h: Line breaks and indenting
>         fixed to follow the libstdc++ standard.
>         * include/experimental/bits/simd_builtin.h: Likewise.
>         * include/experimental/bits/simd_fixed_size.h: Likewise.
>         * include/experimental/bits/simd_neon.h: Likewise.
>         * include/experimental/bits/simd_ppc.h: Likewise.
>         * include/experimental/bits/simd_scalar.h: Likewise.
>         * include/experimental/bits/simd_x86.h: Likewise.
> ---
>  libstdc++-v3/include/experimental/bits/simd.h | 473 ++++++------
>  .../include/experimental/bits/simd_builtin.h  | 692 +++++++++---------
>  .../experimental/bits/simd_fixed_size.h       | 228 +++---
>  .../include/experimental/bits/simd_neon.h     |  24 +-
>  .../include/experimental/bits/simd_ppc.h      |   3 +-
>  .../include/experimental/bits/simd_scalar.h   | 362 +++++----
>  .../include/experimental/bits/simd_x86.h      |  90 ++-
>  7 files changed, 942 insertions(+), 930 deletions(-)
>
>
> --
> ──────────────────────────────────────────────────────────────────────────
>  Dr. Matthias Kretz                           https://mattkretz.github.io
>  GSI Helmholtz Centre for Heavy Ion Research               https://gsi.de
>  stdₓ::simd
> ──────────────────────────────────────────────────────────────────────────

  reply	other threads:[~2023-02-24 17:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  8:48 [PATCH 0/8] std::experimental::simd patchset Matthias Kretz
2023-02-23  8:49 ` [PATCH 1/8] libstdc++: Simplify three helper functions into one Matthias Kretz
2023-02-23 11:05   ` Jonathan Wakely
2023-02-23  8:49 ` [PATCH 2/8] libstdc++: Fix simd build failure on clang Matthias Kretz
2023-02-23 11:06   ` Jonathan Wakely
2023-02-23  8:49 ` [PATCH 3/8] libstdc++: More efficient masked inc-/decrement implementation Matthias Kretz
2023-02-24 17:12   ` Jonathan Wakely
2023-02-23  8:49 ` [PATCH 4/8] libstdc++: Add missing constexpr on simd shift implementation Matthias Kretz
2023-02-23 11:07   ` Jonathan Wakely
2023-02-23 11:33     ` Matthias Kretz
2023-02-23  8:49 ` [PATCH 5/8] libstdc++: Always-inline most of non-cmath fixed_size implementation Matthias Kretz
2023-02-24 17:10   ` Jonathan Wakely
2023-02-23  8:50 ` [PATCH 6/8] libstdc++: Fix formatting Matthias Kretz
2023-02-24 17:14   ` Jonathan Wakely [this message]
2023-02-24 18:44     ` Matthias Kretz
2023-02-23  8:50 ` [PATCH 7/8] libstdc++: Fix -Wsign-compare issue Matthias Kretz
2023-02-23 11:07   ` Jonathan Wakely
2023-02-23  8:50 ` [PATCH 8/8] libstdc++: Test that integral simd reductions are precise Matthias Kretz
2023-02-23 11:08   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACb0b4kcarNm2RrM4CYrOfdBuyTJC+2G+d9UPiR8mfihnrNVKA@mail.gmail.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=m.kretz@gsi.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).