From: Jonathan Wakely <jwakely@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [RFC] libstdc++: Make --enable-libstdcxx-backtrace=auto default to yes
Date: Fri, 1 Sep 2023 17:10:08 +0100 [thread overview]
Message-ID: <CACb0b4ksG4be+3QJhb+jFUS+8EZc3Dm28ra_W7+XC+MN-k0xCA@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4kZZ45b3NHy73hT71qoAfWw1en2ve5ay10N6uhsznxQ5Q@mail.gmail.com>
On Fri, 1 Sept 2023 at 12:16, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On Wed, 23 Aug 2023 at 17:03, Jonathan Wakely via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
> >
> > Any objections to this? It's a C++23 feture, so should be enabled by
> > default.
>
> I've pushed this to trunk, so let's see what breaks!
This modules header broke on aarch64, of course:
FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)
>
>
> >
> > -- >8 --
> >
> > This causes libstdc++_libbacktrace.a to be built by default. This might
> > fail on some targets, in which case we can make the 'auto' choice expand
> > to either 'yes' or 'no' depending on the target.
> >
> > libstdc++-v3/ChangeLog:
> >
> > * acinclude.m4 (GLIBCXX_ENABLE_BACKTRACE): Default to yes.
> > * configure: Regenerate.
> > ---
> > libstdc++-v3/acinclude.m4 | 2 +-
> > libstdc++-v3/configure | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
> > index b25378eaace..50c808c6b2d 100644
> > --- a/libstdc++-v3/acinclude.m4
> > +++ b/libstdc++-v3/acinclude.m4
> > @@ -5481,7 +5481,7 @@ BACKTRACE_CPPFLAGS="$BACKTRACE_CPPFLAGS -DBACKTRACE_ELF_SIZE=$elfsize"
> >
> > AC_MSG_CHECKING([whether to build libbacktrace support])
> > if test "$enable_libstdcxx_backtrace" = "auto"; then
> > - enable_libstdcxx_backtrace=no
> > + enable_libstdcxx_backtrace=yes
> > fi
> > AC_MSG_RESULT($enable_libstdcxx_backtrace)
> > if test "$enable_libstdcxx_backtrace" = "yes"; then
> >
next prev parent reply other threads:[~2023-09-01 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 16:02 Jonathan Wakely
2023-09-01 11:16 ` Jonathan Wakely
2023-09-01 16:10 ` Jonathan Wakely [this message]
2023-09-04 16:35 ` Hans-Peter Nilsson
2023-09-04 16:46 ` Hans-Peter Nilsson
2023-09-04 16:48 ` Jonathan Wakely
2023-09-06 22:30 ` Jonathan Wakely
2023-09-06 23:09 ` Hans-Peter Nilsson
2023-09-06 23:10 ` Jonathan Wakely
2023-09-06 23:11 ` Jonathan Wakely
2023-09-06 23:51 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4ksG4be+3QJhb+jFUS+8EZc3Dm28ra_W7+XC+MN-k0xCA@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).