From: Jonathan Wakely <jwakely@redhat.com>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: jwakely.gcc@gmail.com, libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [RFC] libstdc++: Make --enable-libstdcxx-backtrace=auto default to yes
Date: Thu, 7 Sep 2023 00:10:26 +0100 [thread overview]
Message-ID: <CACb0b4=gHVpoR2_b-SO3f=ASWei3oAuh03sW4Epg_Vv=YMkY8g@mail.gmail.com> (raw)
In-Reply-To: <20230906230915.9A9EF2042A@pchp3.se.axis.com>
On Thu, 7 Sept 2023 at 00:09, Hans-Peter Nilsson <hp@axis.com> wrote:
>
> > From: Jonathan Wakely <jwakely@redhat.com>
> > Date: Wed, 6 Sep 2023 23:30:08 +0100
>
> > On Mon, 4 Sept 2023 at 17:49, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> > >
> > > On Mon, 4 Sept 2023 at 17:47, Hans-Peter Nilsson via Libstdc++
> > > <libstdc++@gcc.gnu.org> wrote:
> > > >
> > > > > Date: Fri, 1 Sep 2023 12:16:40 +0100
> > > > > Reply-To: Jonathan Wakely <jwakely@redhat.com>
> > > > >
> > > > > On Wed, 23 Aug 2023 at 17:03, Jonathan Wakely via Libstdc++
> > > > > <libstdc++@gcc.gnu.org> wrote:
> > > > > >
> > > > > > Any objections to this? It's a C++23 feture, so should be enabled by
> > > > > > default.
> > > > >
> > > > > I've pushed this to trunk, so let's see what breaks!
> > > > >
> > > > >
> > > > > >
> > > > > > -- >8 --
> > > > > >
> > > > > > This causes libstdc++_libbacktrace.a to be built by default. This might
> > > > > > fail on some targets, in which case we can make the 'auto' choice expand
> > > > > > to either 'yes' or 'no' depending on the target.
> > > > > >
> > > > > > libstdc++-v3/ChangeLog:
> > > > > >
> > > > > > * acinclude.m4 (GLIBCXX_ENABLE_BACKTRACE): Default to yes.
> > > > > > * configure: Regenerate.
> > > >
> > > > Incidentally, should check_effective_target_stacktrace in
> > > > libstdc++.exp also be adjusted to match; removing the
> > > > _GLIBCXX_HOSTED condition?
> > >
> > > No, it should still depend on is_hosted. The acinclude.m4 macro should
> > > check that.
> >
> > Done in r14-3761-g6de5f5a4fe85bd
>
> Aha, that's what you meant. I thought you meant that just
> check_effective_target_stacktrace should be gated on
> $is_hosted.
>
> Yeah, it makes sense not to have backtrace enabled by
> default for ! $is_hosted. On the other hand, bare-iron
> targets like cris-elf apparently *are* hosted, according to
> "#if __STDC_HOSTED__". I guess I'll have to dig into what
> the definition of "hosted" is, because I don't agree by the
> layman obvious definition. Maybe there's a bug to fix.
I don't think there's a bug. $is_hosted is true for
--enable-hosted-libstdcxx which is on by default.
> There sure are many yaks to shave these days.
>
> brgds, H-P
>
next prev parent reply other threads:[~2023-09-06 23:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 16:02 Jonathan Wakely
2023-09-01 11:16 ` Jonathan Wakely
2023-09-01 16:10 ` Jonathan Wakely
2023-09-04 16:35 ` Hans-Peter Nilsson
2023-09-04 16:46 ` Hans-Peter Nilsson
2023-09-04 16:48 ` Jonathan Wakely
2023-09-06 22:30 ` Jonathan Wakely
2023-09-06 23:09 ` Hans-Peter Nilsson
2023-09-06 23:10 ` Jonathan Wakely [this message]
2023-09-06 23:11 ` Jonathan Wakely
2023-09-06 23:51 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=gHVpoR2_b-SO3f=ASWei3oAuh03sW4Epg_Vv=YMkY8g@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).