From: Jonathan Wakely <email@example.com>
To: Xi Ruoyao <firstname.lastname@example.org>
Cc: Rainer Orth <email@example.com>,
Jonathan Wakely <firstname.lastname@example.org>,
Subject: Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts
Date: Fri, 24 Jun 2022 13:38:25 +0100 [thread overview]
Message-ID: <CACb0b4mJ0ek-DDBm91=HMco=EDrxsSva6oEgyz4WA8pkCAcePA@mail.gmail.com> (raw)
On Fri, 24 Jun 2022 at 13:37, Xi Ruoyao <email@example.com> wrote:
> On Fri, 2022-06-24 at 13:41 +0200, Rainer Orth wrote:
> > Hi Jonathan,
> > > > > I'll need some rework as Rainer told me "grep -E" may not work on some
> > > > > Solaris systems w/o GNU grep, and the code snippet in extract_symvers.in
> > > > > is exactly for Solaris...
> > > >
> > > > I checked that, and it's not :-)
> > > >
> > > > The egrep uses in extract_symvers.in are for everything *except*
> > > > SunOS. For Solaris we use the scripts/extract_symvers.pl script
> > > > instead.
> I misread the case statement :(.
> > > > Your change might break generation of Doxygen API docs on Solaris, but
> > > > maybe we can live with that.
> > >
> > > /usr/xpg4/bin/grep supports the -E flag, so I was going to say that
> > > it's acceptable to require that version in the PATH when generating
> > > the API docs with doxygen. But in fact that script already assumes GNU
> > indeed: for a niche/developer-only use, the bar of tool requirements can
> > be higher IMO. Besides, /usr/gnu/bin/grep is there, too (or could be;
> > both /usr/xpg4/bin/grep and /usr/gnu/bin/grep live in separate packages
> > that may or may not be installed).
> > I just want to make the entry barries for normal builds as low as
> > possible.
> Pushed as r13-1242 with ChangeLog fix, as compatibility-related stuff
> "resolved" and this does not depend on other patches in the series.
prev parent reply other threads:[~2022-06-24 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <firstname.lastname@example.org>
2022-06-24 7:02 ` Xi Ruoyao
2022-06-24 10:00 ` Jonathan Wakely
2022-06-24 11:08 ` Xi Ruoyao
2022-06-24 11:18 ` Jonathan Wakely
2022-06-24 11:35 ` Jonathan Wakely
2022-06-24 11:41 ` Rainer Orth
2022-06-24 12:37 ` Xi Ruoyao
2022-06-24 12:38 ` Jonathan Wakely [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).