Re: [PATCH] libstdc++: Export the __gnu_cxx::zoneinfo_dir_override symbol.

[Jonathan Wakely <jwakely@redhat.com>]

On Wed, 4 Jan 2023 at 17:14, Jakub Jelinek wrote:
>
> On Wed, Jan 04, 2023 at 03:17:42PM +0000, Jonathan Wakely via Gcc-patches wrote:
> > On Sat, 24 Dec 2022 at 12:21, Iain Sandoe <iain@sandoe.co.uk> wrote:
> > >
> > >
> > >
> > > > On 24 Dec 2022, at 12:12, Jonathan Wakely wrote:
> > > >
> > > >
> > > >
> > > > On Sat, 24 Dec 2022, 11:35 Iain Sandoe via Libstdc++, <libstdc++@gcc.gnu.org> wrote:
> > > >  If this is not the right place to export the symbol (or you do not want
> > > >  to export it in the general case), I can always add a platform-specific
> > > >  file for it.  So far, tested on x86_64-darwin21, wider testing will
> > > >  follow over the holidays.
> > > >
> > > >  OK for trunk?
> > > >
> > > > I'd like to check if this causes the undefined weak symbol to be exported on ELF,
> > >
> > > I’d expect so, since it’s in the common file.
> >
> > hppa-hp-hpux* wants this symbol to be defined anyway (see PR 108228),
> > so please push your patch to trunk.
>
> Isn't it wrong though to export it with GLIBCXX_3.4 symbol version?
> I mean, if it wasn't exported in GCC 3.4 libstdc++.so, then it shouldn't
> be in that symver.  Perhaps GLIBCXX_3.4.31 instead?

Oops, yes! I didn't notice that! I'll move it.

Thanks for catching that.