From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][_Hashtable] Use RAII to restore Rehash state
Date: Thu, 26 Oct 2023 11:14:51 +0100 [thread overview]
Message-ID: <CACb0b4n2TYfAr2dTRspLWjnHu3xw5kDxoY7CghyzeAkBdS63iQ@mail.gmail.com> (raw)
In-Reply-To: <7f61df18-dd99-4ff5-9fcd-8ca7820403d4@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]
On Thu, 26 Oct 2023 at 06:18, François Dumont <frs.dumont@gmail.com> wrote:
> libstdc++: [_Hashtable] Use RAII type to manage rehash functor state
>
> Replace usage of __try/__catch with a RAII type to restore rehash
> functor
> state when needed.
>
I'm reviewing this now, but could I request that you attach patches as .txt
files in gmail please?
When you attach a .patch file gmail decides to give it content-type
text/x-patch and base64 encode it, and set content-disposition: attachment,
which mean it looks like this when received:
https://inbox.sourceware.org/libstdc++/7f61df18-dd99-4ff5-9fcd-8ca7820403d4@gmail.com/raw
It's hard to reply inline when the patch needs to be downloaded separately.
If you name the file .txt then gmail just shows it in the mail body
(conetnt-disposition: inline) and it's much easier to reply.
Anyway, I'll finish reviewing this one now that I've downloaded it and
manually pasted the patch into my reply.
>
> libstdc++-v3/ChangeLog:
>
> * include/bits/hashtable_policy.h (_RehashStateGuard): New.
> (_Insert_base<>::_M_insert_range(_IIt, _IIt, const
> _NodeGet&, false_type)):
> Adapt.
> * include/bits/hashtable.h (__rehash_guard_t): New.
> (__rehash_state): Remove.
> (_M_rehash): Remove.
> (_M_rehash_aux): Rename into _M_rehash.
> (_M_assign_elements, _M_insert_unique_node,
> _M_insert_multi_node): Adapt.
> (rehash): Adapt.
>
>
> Tested under Linux x64.
>
> Ok to commit ?
>
> François
>
next prev parent reply other threads:[~2023-10-26 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 5:18 François Dumont
2023-10-26 10:14 ` Jonathan Wakely [this message]
2023-10-26 10:43 ` Jonathan Wakely
2023-10-26 20:52 ` François Dumont
2023-11-09 8:11 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4n2TYfAr2dTRspLWjnHu3xw5kDxoY7CghyzeAkBdS63iQ@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).