From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: Ken Matsui <kmatsui@gcc.gnu.org>,
gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v3 1/3] c++, libstdc++: Implement __is_arithmetic built-in trait
Date: Tue, 8 Aug 2023 21:04:47 +0100 [thread overview]
Message-ID: <CACb0b4nHX65eDX35sYUUJdHmes-6iV_99k0Uzz+F6M1K+vwHcA@mail.gmail.com> (raw)
In-Reply-To: <18bd2387-fb96-6ddd-db17-39d3450bd888@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3539 bytes --]
On Sat, 22 Jul 2023 at 14:51, François Dumont via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:
>
> On 18/07/2023 08:27, Ken Matsui via Libstdc++ wrote:
> > This patch implements built-in trait for std::is_arithmetic.
> >
> > gcc/cp/ChangeLog:
> >
> > * cp-trait.def: Define __is_arithmetic.
> > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_ARITHMETIC.
> > * semantics.cc (trait_expr_value): Likewise.
> > (finish_trait_expr): Likewise.
> >
> > gcc/testsuite/ChangeLog:
> >
> > * g++.dg/ext/has-builtin-1.C: Test existence of __is_arithmetic.
> > * g++.dg/ext/is_arithmetic.C: New test.
> > * g++.dg/tm/pr46567.C (__is_arithmetic): Rename to ...
> > (__is_arith): ... this.
> > * g++.dg/torture/pr57107.C: Likewise.
> >
> > libstdc++-v3/ChangeLog:
> >
> > * include/bits/cpp_type_traits.h (__is_arithmetic): Rename to ...
> > (__is_arith): ... this.
> > * include/c_global/cmath: Use __is_arith instead.
> > * include/c_std/cmath: Likewise.
> > * include/tr1/cmath: Likewise.
> >
> > Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
> > ---
> > gcc/cp/constraint.cc | 3 ++
> > gcc/cp/cp-trait.def | 1 +
> > gcc/cp/semantics.cc | 4 ++
> > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++
> > gcc/testsuite/g++.dg/ext/is_arithmetic.C | 33 ++++++++++++++
> > gcc/testsuite/g++.dg/tm/pr46567.C | 6 +--
> > gcc/testsuite/g++.dg/torture/pr57107.C | 4 +-
> > libstdc++-v3/include/bits/cpp_type_traits.h | 4 +-
> > libstdc++-v3/include/c_global/cmath | 48 ++++++++++-----------
> > libstdc++-v3/include/c_std/cmath | 24 +++++------
> > libstdc++-v3/include/tr1/cmath | 24 +++++------
> > 11 files changed, 99 insertions(+), 55 deletions(-)
> > create mode 100644 gcc/testsuite/g++.dg/ext/is_arithmetic.C
>
>
[...]
> diff --git a/libstdc++-v3/include/bits/cpp_type_traits.h
> b/libstdc++-v3/include/bits/cpp_type_traits.h
> > index 4312f32a4e0..d00d1ea8d75 100644
> > --- a/libstdc++-v3/include/bits/cpp_type_traits.h
> > +++ b/libstdc++-v3/include/bits/cpp_type_traits.h
> > @@ -381,7 +381,7 @@ __INT_N(__GLIBCXX_TYPE_INT_N_3)
> > // An arithmetic type is an integer type or a floating point type
> > //
> > template<typename _Tp>
> > - struct __is_arithmetic
> > + struct __is_arith
> > : public __traitor<__is_integer<_Tp>, __is_floating<_Tp> >
> > { };
>
> 'ptr' is a well known alias of 'pointer', I wouldn't say the same for
> 'arith' and 'arithmetic'.
>
> But wait for a native-english feedback to change anything.
>
>
I think it's clear enough. This is only an internal trait anyway, not part
of a public API.
Since all uses are with the __enable_if trait, we could add this helper and
get rid of __is_arithmetic completely:
template<typename _Tp, typename _Res,
bool = __is_integer<_Tp>::__value ||
__is_floating<_Tp>::__value>
struct __enable_if_arithmetic { };
template<typename _Tp, typename _Res>
struct __enable_if_arithmetic<_Tp, _Res, true> { typedef _Res __type; };
And similarly for a two-argument __enable_if_both_arithmetic helper.
But we can consider doing that later, I think __is_arith is fine for now.
The libstdc++ parts of this patch are OK (but wait for approval for the
compiler changes from a G++ maintainer before pushing).
next prev parent reply other threads:[~2023-08-08 20:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 12:57 [PATCH 1/2] c++, libstdc++: implement " Ken Matsui
2023-07-09 12:57 ` [PATCH 2/2] libstdc++: use new built-in trait __is_arithmetic Ken Matsui
2023-07-09 13:03 ` [PATCH 1/2] c++, libstdc++: implement __is_arithmetic built-in trait Ken Matsui
2023-07-15 4:55 ` [PATCH v2 1/3] c++, libstdc++: Implement " Ken Matsui
2023-07-15 4:55 ` [PATCH v2 2/3] libstdc++: Optimize is_arithmetic performance by __is_arithmetic built-in Ken Matsui
2023-07-16 12:32 ` François Dumont
2023-07-17 4:48 ` Ken Matsui
2023-07-22 13:39 ` François Dumont
2023-08-08 20:09 ` Jonathan Wakely
2023-08-08 20:28 ` Jonathan Wakely
2023-07-15 4:55 ` [PATCH v2 3/3] libstdc++: Optimize is_fundamental " Ken Matsui
2023-07-15 5:07 ` Ken Matsui
2023-07-16 12:41 ` François Dumont
2023-07-17 4:49 ` Ken Matsui
2023-07-18 6:24 ` Ken Matsui
2023-07-18 6:26 ` Ken Matsui
2023-08-08 20:14 ` Jonathan Wakely
2023-08-31 13:47 ` Ken Matsui
2023-07-22 13:45 ` François Dumont
2023-08-08 20:18 ` Jonathan Wakely
2023-08-31 13:57 ` Ken Matsui
2023-08-31 15:01 ` Ken Matsui
2023-07-16 12:27 ` [PATCH v2 1/3] c++, libstdc++: Implement __is_arithmetic built-in trait François Dumont
2023-07-17 4:46 ` Ken Matsui
2023-07-18 6:27 ` [PATCH v3 " Ken Matsui
2023-07-18 6:27 ` [PATCH v3 2/3] libstdc++: Optimize is_arithmetic performance by __is_arithmetic built-in Ken Matsui
2023-07-18 6:27 ` [PATCH v3 3/3] libstdc++: Optimize is_fundamental " Ken Matsui
2023-07-18 7:40 ` [PATCH v4 1/4] c++, libstdc++: Implement __is_arithmetic built-in trait Ken Matsui
2023-07-18 7:40 ` [PATCH v4 2/4] libstdc++: Optimize is_arithmetic trait performance Ken Matsui
2023-07-18 7:40 ` [PATCH v4 3/4] libstdc++: Optimize is_fundamental " Ken Matsui
2023-07-18 7:40 ` [PATCH v4 4/4] libstdc++: Optimize is_compound " Ken Matsui
2023-08-08 20:33 ` Jonathan Wakely
2023-09-01 10:40 ` Ken Matsui
2023-07-22 13:50 ` [PATCH v3 1/3] c++, libstdc++: Implement __is_arithmetic built-in trait François Dumont
2023-08-08 20:04 ` Jonathan Wakely [this message]
2023-09-01 11:25 ` [PATCH v5 1/4] " Ken Matsui
2023-09-01 11:25 ` [PATCH v5 2/4] libstdc++: Optimize is_arithmetic trait performance Ken Matsui
2023-09-01 11:25 ` [PATCH v5 3/4] libstdc++: Optimize is_fundamental " Ken Matsui
2023-09-01 11:25 ` [PATCH v5 4/4] libstdc++: Optimize is_compound " Ken Matsui
2023-09-04 10:27 ` [PATCH v5 1/4] c++, libstdc++: Implement __is_arithmetic built-in trait Jonathan Wakely
2023-09-04 15:00 ` Ken Matsui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4nHX65eDX35sYUUJdHmes-6iV_99k0Uzz+F6M1K+vwHcA@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kmatsui@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).