public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Ken Matsui <kmatsui@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v5 1/4] c++, libstdc++: Implement __is_arithmetic built-in trait
Date: Mon, 4 Sep 2023 11:27:33 +0100	[thread overview]
Message-ID: <CACb0b4niZ-X-EVjudaeiBCKrw_+_eSHC2f4OSKvBFGXYfXbMVA@mail.gmail.com> (raw)
In-Reply-To: <20230901112510.1562-1-kmatsui@gcc.gnu.org>

On Fri, 1 Sept 2023 at 12:25, Ken Matsui via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> This patch implements built-in trait for std::is_arithmetic.

The libstdc++-v3 parts are OK for trunk.


>
> gcc/cp/ChangeLog:
>
>         * cp-trait.def: Define __is_arithmetic.
>         * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_ARITHMETIC.
>         * semantics.cc (trait_expr_value): Likewise.
>         (finish_trait_expr): Likewise.
>
> gcc/testsuite/ChangeLog:
>
>         * g++.dg/ext/has-builtin-1.C: Test existence of __is_arithmetic.
>         * g++.dg/ext/is_arithmetic.C: New test.
>         * g++.dg/tm/pr46567.C (__is_arithmetic): Rename to ...
>         (__is_arith): ... this.
>         * g++.dg/torture/pr57107.C: Likewise.
>
> libstdc++-v3/ChangeLog:
>
>         * include/bits/cpp_type_traits.h (__is_arithmetic): Rename to ...
>         (__is_arith): ... this.
>         * include/c_global/cmath: Use __is_arith instead.
>         * include/c_std/cmath: Likewise.
>         * include/tr1/cmath: Likewise.
>
> Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
> ---
>  gcc/cp/constraint.cc                        |  3 ++
>  gcc/cp/cp-trait.def                         |  1 +
>  gcc/cp/semantics.cc                         |  4 ++
>  gcc/testsuite/g++.dg/ext/has-builtin-1.C    |  3 ++
>  gcc/testsuite/g++.dg/ext/is_arithmetic.C    | 33 ++++++++++++++
>  gcc/testsuite/g++.dg/tm/pr46567.C           |  6 +--
>  gcc/testsuite/g++.dg/torture/pr57107.C      |  4 +-
>  libstdc++-v3/include/bits/cpp_type_traits.h |  4 +-
>  libstdc++-v3/include/c_global/cmath         | 48 ++++++++++-----------
>  libstdc++-v3/include/c_std/cmath            | 24 +++++------
>  libstdc++-v3/include/tr1/cmath              | 24 +++++------
>  11 files changed, 99 insertions(+), 55 deletions(-)
>  create mode 100644 gcc/testsuite/g++.dg/ext/is_arithmetic.C
>
> diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc
> index 8cf0f2d0974..bd517d08843 100644
> --- a/gcc/cp/constraint.cc
> +++ b/gcc/cp/constraint.cc
> @@ -3754,6 +3754,9 @@ diagnose_trait_expr (tree expr, tree args)
>      case CPTK_IS_AGGREGATE:
>        inform (loc, "  %qT is not an aggregate", t1);
>        break;
> +    case CPTK_IS_ARITHMETIC:
> +      inform (loc, "  %qT is not an arithmetic type", t1);
> +      break;
>      case CPTK_IS_TRIVIALLY_COPYABLE:
>        inform (loc, "  %qT is not trivially copyable", t1);
>        break;
> diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def
> index 8b7fece0cc8..a95aeeaf778 100644
> --- a/gcc/cp/cp-trait.def
> +++ b/gcc/cp/cp-trait.def
> @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially_assignable", 2)
>  DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible", -1)
>  DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1)
>  DEFTRAIT_EXPR (IS_UNION, "__is_union", 1)
> +DEFTRAIT_EXPR (IS_ARITHMETIC, "__is_arithmetic", 1)
>  DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2)
>  DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2)
>  /* FIXME Added space to avoid direct usage in GCC 13.  */
> diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc
> index 8fb47fd179e..4531f047d73 100644
> --- a/gcc/cp/semantics.cc
> +++ b/gcc/cp/semantics.cc
> @@ -12118,6 +12118,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2)
>      case CPTK_IS_UNION:
>        return type_code1 == UNION_TYPE;
>
> +    case CPTK_IS_ARITHMETIC:
> +      return ARITHMETIC_TYPE_P (type1);
> +
>      case CPTK_IS_ASSIGNABLE:
>        return is_xible (MODIFY_EXPR, type1, type2);
>
> @@ -12296,6 +12299,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2)
>      case CPTK_IS_ENUM:
>      case CPTK_IS_UNION:
>      case CPTK_IS_SAME:
> +    case CPTK_IS_ARITHMETIC:
>        break;
>
>      case CPTK_IS_LAYOUT_COMPATIBLE:
> diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C
> index f343e153e56..3d63b0101d1 100644
> --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C
> +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C
> @@ -146,3 +146,6 @@
>  #if !__has_builtin (__remove_cvref)
>  # error "__has_builtin (__remove_cvref) failed"
>  #endif
> +#if !__has_builtin (__is_arithmetic)
> +# error "__has_builtin (__is_arithmetic) failed"
> +#endif
> diff --git a/gcc/testsuite/g++.dg/ext/is_arithmetic.C b/gcc/testsuite/g++.dg/ext/is_arithmetic.C
> new file mode 100644
> index 00000000000..fd35831f646
> --- /dev/null
> +++ b/gcc/testsuite/g++.dg/ext/is_arithmetic.C
> @@ -0,0 +1,33 @@
> +// { dg-do compile { target c++11 } }
> +
> +#include <testsuite_tr1.h>
> +
> +using namespace __gnu_test;
> +
> +#define SA(X) static_assert((X),#X)
> +#define SA_TEST_CATEGORY(TRAIT, TYPE, EXPECT)  \
> +  SA(TRAIT(TYPE) == EXPECT);                                   \
> +  SA(TRAIT(const TYPE) == EXPECT);                             \
> +  SA(TRAIT(volatile TYPE) == EXPECT);                  \
> +  SA(TRAIT(const volatile TYPE) == EXPECT)
> +
> +SA_TEST_CATEGORY(__is_arithmetic, void, false);
> +
> +SA_TEST_CATEGORY(__is_arithmetic, char, true);
> +SA_TEST_CATEGORY(__is_arithmetic, signed char, true);
> +SA_TEST_CATEGORY(__is_arithmetic, unsigned char, true);
> +SA_TEST_CATEGORY(__is_arithmetic, wchar_t, true);
> +SA_TEST_CATEGORY(__is_arithmetic, short, true);
> +SA_TEST_CATEGORY(__is_arithmetic, unsigned short, true);
> +SA_TEST_CATEGORY(__is_arithmetic, int, true);
> +SA_TEST_CATEGORY(__is_arithmetic, unsigned int, true);
> +SA_TEST_CATEGORY(__is_arithmetic, long, true);
> +SA_TEST_CATEGORY(__is_arithmetic, unsigned long, true);
> +SA_TEST_CATEGORY(__is_arithmetic, long long, true);
> +SA_TEST_CATEGORY(__is_arithmetic, unsigned long long, true);
> +SA_TEST_CATEGORY(__is_arithmetic, float, true);
> +SA_TEST_CATEGORY(__is_arithmetic, double, true);
> +SA_TEST_CATEGORY(__is_arithmetic, long double, true);
> +
> +// Sanity check.
> +SA_TEST_CATEGORY(__is_arithmetic, ClassType, false);
> diff --git a/gcc/testsuite/g++.dg/tm/pr46567.C b/gcc/testsuite/g++.dg/tm/pr46567.C
> index 6d791484448..8d2d3eb6c5a 100644
> --- a/gcc/testsuite/g++.dg/tm/pr46567.C
> +++ b/gcc/testsuite/g++.dg/tm/pr46567.C
> @@ -217,16 +217,16 @@ namespace std __attribute__ ((__visibility__ ("default"))) {
>        typedef __true_type __type;
>      };
>    template<typename _Tp>
> -    struct __is_arithmetic
> +    struct __is_arith
>      : public __traitor<__is_integer<_Tp>, __is_floating<_Tp> >
>      { };
>    template<typename _Tp>
>      struct __is_fundamental
> -    : public __traitor<__is_void<_Tp>, __is_arithmetic<_Tp> >
> +    : public __traitor<__is_void<_Tp>, __is_arith<_Tp> >
>      { };
>    template<typename _Tp>
>      struct __is_scalar
> -    : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> >
> +    : public __traitor<__is_arith<_Tp>, __is_pointer<_Tp> >
>      { };
>    template<typename _Tp>
>      struct __is_char
> diff --git a/gcc/testsuite/g++.dg/torture/pr57107.C b/gcc/testsuite/g++.dg/torture/pr57107.C
> index 4dbd32bd298..ecbe99db4f8 100644
> --- a/gcc/testsuite/g++.dg/torture/pr57107.C
> +++ b/gcc/testsuite/g++.dg/torture/pr57107.C
> @@ -25,9 +25,9 @@ namespace std __attribute__ ((__visibility__ ("default"))) {
>         enum {
>             __value = 0 };
>      };
> -    template<typename _Tp>     struct __is_arithmetic     : public __traitor<__is_integer<_Tp>, __is_floating<_Tp> >     {
> +    template<typename _Tp>     struct __is_arith     : public __traitor<__is_integer<_Tp>, __is_floating<_Tp> >     {
>      };
> -    template<typename _Tp>     struct __is_scalar     : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> >     {
> +    template<typename _Tp>     struct __is_scalar     : public __traitor<__is_arith<_Tp>, __is_pointer<_Tp> >     {
>      };
>  }
>  namespace __gnu_cxx __attribute__ ((__visibility__ ("default"))) {
> diff --git a/libstdc++-v3/include/bits/cpp_type_traits.h b/libstdc++-v3/include/bits/cpp_type_traits.h
> index 4312f32a4e0..d00d1ea8d75 100644
> --- a/libstdc++-v3/include/bits/cpp_type_traits.h
> +++ b/libstdc++-v3/include/bits/cpp_type_traits.h
> @@ -381,7 +381,7 @@ __INT_N(__GLIBCXX_TYPE_INT_N_3)
>    // An arithmetic type is an integer type or a floating point type
>    //
>    template<typename _Tp>
> -    struct __is_arithmetic
> +    struct __is_arith
>      : public __traitor<__is_integer<_Tp>, __is_floating<_Tp> >
>      { };
>
> @@ -390,7 +390,7 @@ __INT_N(__GLIBCXX_TYPE_INT_N_3)
>    //
>    template<typename _Tp>
>      struct __is_scalar
> -    : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> >
> +    : public __traitor<__is_arith<_Tp>, __is_pointer<_Tp> >
>      { };
>
>    //
> diff --git a/libstdc++-v3/include/c_global/cmath b/libstdc++-v3/include/c_global/cmath
> index b0ba395eb5c..da3ef537c38 100644
> --- a/libstdc++-v3/include/c_global/cmath
> +++ b/libstdc++-v3/include/c_global/cmath
> @@ -1255,8 +1255,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #ifndef __CORRECT_ISO_CPP11_MATH_H_PROTO_INT
>    template<typename _Tp, typename _Up>
>      constexpr typename
> -    __gnu_cxx::__enable_if<(__is_arithmetic<_Tp>::__value
> -                           && __is_arithmetic<_Up>::__value), bool>::__type
> +    __gnu_cxx::__enable_if<(__is_arith<_Tp>::__value
> +                           && __is_arith<_Up>::__value), bool>::__type
>      isgreater(_Tp __x, _Up __y)
>      {
>        typedef typename __gnu_cxx::__promote_2<_Tp, _Up>::__type __type;
> @@ -1281,8 +1281,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #ifndef __CORRECT_ISO_CPP11_MATH_H_PROTO_INT
>    template<typename _Tp, typename _Up>
>      constexpr typename
> -    __gnu_cxx::__enable_if<(__is_arithmetic<_Tp>::__value
> -                           && __is_arithmetic<_Up>::__value), bool>::__type
> +    __gnu_cxx::__enable_if<(__is_arith<_Tp>::__value
> +                           && __is_arith<_Up>::__value), bool>::__type
>      isgreaterequal(_Tp __x, _Up __y)
>      {
>        typedef typename __gnu_cxx::__promote_2<_Tp, _Up>::__type __type;
> @@ -1307,8 +1307,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #ifndef __CORRECT_ISO_CPP11_MATH_H_PROTO_INT
>    template<typename _Tp, typename _Up>
>      constexpr typename
> -    __gnu_cxx::__enable_if<(__is_arithmetic<_Tp>::__value
> -                           && __is_arithmetic<_Up>::__value), bool>::__type
> +    __gnu_cxx::__enable_if<(__is_arith<_Tp>::__value
> +                           && __is_arith<_Up>::__value), bool>::__type
>      isless(_Tp __x, _Up __y)
>      {
>        typedef typename __gnu_cxx::__promote_2<_Tp, _Up>::__type __type;
> @@ -1333,8 +1333,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #ifndef __CORRECT_ISO_CPP11_MATH_H_PROTO_INT
>    template<typename _Tp, typename _Up>
>      constexpr typename
> -    __gnu_cxx::__enable_if<(__is_arithmetic<_Tp>::__value
> -                           && __is_arithmetic<_Up>::__value), bool>::__type
> +    __gnu_cxx::__enable_if<(__is_arith<_Tp>::__value
> +                           && __is_arith<_Up>::__value), bool>::__type
>      islessequal(_Tp __x, _Up __y)
>      {
>        typedef typename __gnu_cxx::__promote_2<_Tp, _Up>::__type __type;
> @@ -1359,8 +1359,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #ifndef __CORRECT_ISO_CPP11_MATH_H_PROTO_INT
>    template<typename _Tp, typename _Up>
>      constexpr typename
> -    __gnu_cxx::__enable_if<(__is_arithmetic<_Tp>::__value
> -                           && __is_arithmetic<_Up>::__value), bool>::__type
> +    __gnu_cxx::__enable_if<(__is_arith<_Tp>::__value
> +                           && __is_arith<_Up>::__value), bool>::__type
>      islessgreater(_Tp __x, _Up __y)
>      {
>        typedef typename __gnu_cxx::__promote_2<_Tp, _Up>::__type __type;
> @@ -1385,8 +1385,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #ifndef __CORRECT_ISO_CPP11_MATH_H_PROTO_INT
>    template<typename _Tp, typename _Up>
>      constexpr typename
> -    __gnu_cxx::__enable_if<(__is_arithmetic<_Tp>::__value
> -                           && __is_arithmetic<_Up>::__value), bool>::__type
> +    __gnu_cxx::__enable_if<(__is_arith<_Tp>::__value
> +                           && __is_arith<_Up>::__value), bool>::__type
>      isunordered(_Tp __x, _Up __y)
>      {
>        typedef typename __gnu_cxx::__promote_2<_Tp, _Up>::__type __type;
> @@ -1397,7 +1397,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #else
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      fpclassify(_Tp __f)
>      {
> @@ -1407,7 +1407,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isfinite(_Tp __f)
>      {
> @@ -1416,7 +1416,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isinf(_Tp __f)
>      {
> @@ -1425,7 +1425,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isnan(_Tp __f)
>      {
> @@ -1434,7 +1434,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isnormal(_Tp __f)
>      {
> @@ -1443,7 +1443,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      signbit(_Tp __f)
>      {
> @@ -1452,7 +1452,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isgreater(_Tp __f1, _Tp __f2)
>      {
> @@ -1461,7 +1461,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isgreaterequal(_Tp __f1, _Tp __f2)
>      {
> @@ -1470,7 +1470,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isless(_Tp __f1, _Tp __f2)
>      {
> @@ -1479,7 +1479,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      islessequal(_Tp __f1, _Tp __f2)
>      {
> @@ -1488,7 +1488,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      islessgreater(_Tp __f1, _Tp __f2)
>      {
> @@ -1497,7 +1497,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isunordered(_Tp __f1, _Tp __f2)
>      {
> diff --git a/libstdc++-v3/include/c_std/cmath b/libstdc++-v3/include/c_std/cmath
> index 588ee1e6dc4..c1db699ecdb 100644
> --- a/libstdc++-v3/include/c_std/cmath
> +++ b/libstdc++-v3/include/c_std/cmath
> @@ -467,7 +467,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>  #undef isunordered
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      fpclassify(_Tp __f)
>      {
> @@ -477,7 +477,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isfinite(_Tp __f)
>      {
> @@ -486,7 +486,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isinf(_Tp __f)
>      {
> @@ -495,7 +495,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isnan(_Tp __f)
>      {
> @@ -504,7 +504,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isnormal(_Tp __f)
>      {
> @@ -513,7 +513,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      signbit(_Tp __f)
>      {
> @@ -522,7 +522,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isgreater(_Tp __f1, _Tp __f2)
>      {
> @@ -531,7 +531,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isgreaterequal(_Tp __f1, _Tp __f2)
>      {
> @@ -540,7 +540,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isless(_Tp __f1, _Tp __f2)
>      {
> @@ -549,7 +549,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      islessequal(_Tp __f1, _Tp __f2)
>      {
> @@ -558,7 +558,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      islessgreater(_Tp __f1, _Tp __f2)
>      {
> @@ -567,7 +567,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isunordered(_Tp __f1, _Tp __f2)
>      {
> diff --git a/libstdc++-v3/include/tr1/cmath b/libstdc++-v3/include/tr1/cmath
> index ba1b60cc945..2e80f1d0d00 100644
> --- a/libstdc++-v3/include/tr1/cmath
> +++ b/libstdc++-v3/include/tr1/cmath
> @@ -307,7 +307,7 @@ namespace tr1
>
>    /// Function template definitions [8.16.3].
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      fpclassify(_Tp __f)
>      {
> @@ -317,7 +317,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isfinite(_Tp __f)
>      {
> @@ -326,7 +326,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isinf(_Tp __f)
>      {
> @@ -335,7 +335,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isnan(_Tp __f)
>      {
> @@ -344,7 +344,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isnormal(_Tp __f)
>      {
> @@ -353,7 +353,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      signbit(_Tp __f)
>      {
> @@ -362,7 +362,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isgreater(_Tp __f1, _Tp __f2)
>      {
> @@ -371,7 +371,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isgreaterequal(_Tp __f1, _Tp __f2)
>      {
> @@ -380,7 +380,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isless(_Tp __f1, _Tp __f2)
>      {
> @@ -389,7 +389,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      islessequal(_Tp __f1, _Tp __f2)
>      {
> @@ -398,7 +398,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      islessgreater(_Tp __f1, _Tp __f2)
>      {
> @@ -407,7 +407,7 @@ namespace tr1
>      }
>
>    template<typename _Tp>
> -    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
> +    inline typename __gnu_cxx::__enable_if<__is_arith<_Tp>::__value,
>                                            int>::__type
>      isunordered(_Tp __f1, _Tp __f2)
>      {
> --
> 2.42.0
>


  parent reply	other threads:[~2023-09-04 10:27 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-09 12:57 [PATCH 1/2] c++, libstdc++: implement " Ken Matsui
2023-07-09 12:57 ` [PATCH 2/2] libstdc++: use new built-in trait __is_arithmetic Ken Matsui
2023-07-09 13:03 ` [PATCH 1/2] c++, libstdc++: implement __is_arithmetic built-in trait Ken Matsui
2023-07-15  4:55 ` [PATCH v2 1/3] c++, libstdc++: Implement " Ken Matsui
2023-07-15  4:55   ` [PATCH v2 2/3] libstdc++: Optimize is_arithmetic performance by __is_arithmetic built-in Ken Matsui
2023-07-16 12:32     ` François Dumont
2023-07-17  4:48       ` Ken Matsui
2023-07-22 13:39         ` François Dumont
2023-08-08 20:09     ` Jonathan Wakely
2023-08-08 20:28       ` Jonathan Wakely
2023-07-15  4:55   ` [PATCH v2 3/3] libstdc++: Optimize is_fundamental " Ken Matsui
2023-07-15  5:07     ` Ken Matsui
2023-07-16 12:41     ` François Dumont
2023-07-17  4:49       ` Ken Matsui
2023-07-18  6:24         ` Ken Matsui
2023-07-18  6:26           ` Ken Matsui
2023-08-08 20:14             ` Jonathan Wakely
2023-08-31 13:47               ` Ken Matsui
2023-07-22 13:45           ` François Dumont
2023-08-08 20:18           ` Jonathan Wakely
2023-08-31 13:57             ` Ken Matsui
2023-08-31 15:01               ` Ken Matsui
2023-07-16 12:27   ` [PATCH v2 1/3] c++, libstdc++: Implement __is_arithmetic built-in trait François Dumont
2023-07-17  4:46     ` Ken Matsui
2023-07-18  6:27   ` [PATCH v3 " Ken Matsui
2023-07-18  6:27     ` [PATCH v3 2/3] libstdc++: Optimize is_arithmetic performance by __is_arithmetic built-in Ken Matsui
2023-07-18  6:27     ` [PATCH v3 3/3] libstdc++: Optimize is_fundamental " Ken Matsui
2023-07-18  7:40     ` [PATCH v4 1/4] c++, libstdc++: Implement __is_arithmetic built-in trait Ken Matsui
2023-07-18  7:40       ` [PATCH v4 2/4] libstdc++: Optimize is_arithmetic trait performance Ken Matsui
2023-07-18  7:40       ` [PATCH v4 3/4] libstdc++: Optimize is_fundamental " Ken Matsui
2023-07-18  7:40       ` [PATCH v4 4/4] libstdc++: Optimize is_compound " Ken Matsui
2023-08-08 20:33         ` Jonathan Wakely
2023-09-01 10:40           ` Ken Matsui
2023-07-22 13:50     ` [PATCH v3 1/3] c++, libstdc++: Implement __is_arithmetic built-in trait François Dumont
2023-08-08 20:04       ` Jonathan Wakely
2023-09-01 11:25   ` [PATCH v5 1/4] " Ken Matsui
2023-09-01 11:25     ` [PATCH v5 2/4] libstdc++: Optimize is_arithmetic trait performance Ken Matsui
2023-09-01 11:25     ` [PATCH v5 3/4] libstdc++: Optimize is_fundamental " Ken Matsui
2023-09-01 11:25     ` [PATCH v5 4/4] libstdc++: Optimize is_compound " Ken Matsui
2023-09-04 10:27     ` Jonathan Wakely [this message]
2023-09-04 15:00     ` [PATCH v5 1/4] c++, libstdc++: Implement __is_arithmetic built-in trait Ken Matsui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACb0b4niZ-X-EVjudaeiBCKrw_+_eSHC2f4OSKvBFGXYfXbMVA@mail.gmail.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kmatsui@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).