From: Jonathan Wakely <jwakely@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] libstdc++: Support constexpr global std::string for size < 15 [PR105995]
Date: Fri, 17 Jun 2022 13:32:12 +0100 [thread overview]
Message-ID: <CACb0b4nnw4FCEUBAK3=UAE1gRJnUAU=4ANcx+-6z+Ximb7Kbjg@mail.gmail.com> (raw)
In-Reply-To: <20220616192111.1199662-1-jwakely@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Thu, 16 Jun 2022 at 20:23, Jonathan Wakely via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> Tested x86_64-linux, pushed to trunk.
Somehow I messed up the test in the commit I pushed (but not the one I
tested ... weird).
Fixed at r13-1151-g0f96ac43fa0a5f by the attached patch.
-- >8 --
libstdc++: Add missing #include <string> to new test
Somehow I pushed a different version of this test to the one I actually
tested.
libstdc++-v3/ChangeLog:
* testsuite/21_strings/basic_string/cons/char/105995.cc: Add
missing #include.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 996 bytes --]
commit 0f96ac43fa0a5fdbfce317b274233852d5b46d23
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Jun 17 13:29:05 2022
libstdc++: Add missing #include <string> to new test
Somehow I pushed a different version of this test to the one I actually
tested.
libstdc++-v3/ChangeLog:
* testsuite/21_strings/basic_string/cons/char/105995.cc: Add
missing #include.
diff --git a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/105995.cc b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/105995.cc
index aa8bcba3dca..4764ceff72a 100644
--- a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/105995.cc
+++ b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/105995.cc
@@ -2,6 +2,8 @@
// { dg-do compile { target c++20 } }
// { dg-require-effective-target cxx11_abi }
+#include <string>
+
// PR libstdc++/105995
// Not required by the standard, but supported for QoI.
constexpr std::string pr105995_empty;
prev parent reply other threads:[~2022-06-17 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 19:21 Jonathan Wakely
2022-06-17 12:32 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4nnw4FCEUBAK3=UAE1gRJnUAU=4ANcx+-6z+Ximb7Kbjg@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).