From: Will Hawkins <hawkinsw@obs.cr>
To: "libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Add std:: prefix for forward_iterator_tag
Date: Fri, 19 Aug 2022 16:06:01 -0400 [thread overview]
Message-ID: <CADx9qWh0j3DpAu=FAMATsCK_2iwdT+MTnWpAfNqx5cEFeqAk9A@mail.gmail.com> (raw)
In-Reply-To: <CAH6eHdS14NNEnGWs=WGp6bX5wjprkodEne4i8Wir2OTKgE2nLA@mail.gmail.com>
Okay! Thank you!
It was the only use of forward_iterator_tag in basic_string that did
not have that qualification so I just thought that it would be good to
have for consistency.
Thanks again,
Will
On Fri, Aug 19, 2022 at 2:48 PM Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>
>
>
> On Fri, 19 Aug 2022, 20:01 , <whh8b@obs.cr> wrote:
>>
>> From: Will Hawkins <whh8b@obs.cr>
>>
>> libstdc++-v3/ChangeLog:
>>
>> * include/bits/basic_string (basic_string(const _CharT*, size_type _, const _Alloc&)):
>> Add std:: prefix to forward_iterator_tag.
>
>
> This qualification is not necessary, there is no ADL for that expression, so name lookup cannot possibly find anything except std::forward_iterator_tag.
>
> N.B. patches for libstdc++ need to be CC'd to gcc-patches as well as the libstdc++ list.
>
>
>
>
>> ---
>> libstdc++-v3/include/bits/basic_string.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h
>> index b04fba95678..e7d7833e002 100644
>> --- a/libstdc++-v3/include/bits/basic_string.h
>> +++ b/libstdc++-v3/include/bits/basic_string.h
>> @@ -639,7 +639,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
>> std::__throw_logic_error(__N("basic_string: "
>> "construction from null is not valid"));
>> const _CharT* __end = __s + traits_type::length(__s);
>> - _M_construct(__s, __end, forward_iterator_tag());
>> + _M_construct(__s, __end, std::forward_iterator_tag());
>> }
>>
>> /**
>> --
>> 2.34.1
>>
prev parent reply other threads:[~2022-08-19 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 18:00 whh8b
2022-08-19 18:00 ` whh8b
2022-08-19 18:48 ` Jonathan Wakely
2022-08-19 20:06 ` Will Hawkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADx9qWh0j3DpAu=FAMATsCK_2iwdT+MTnWpAfNqx5cEFeqAk9A@mail.gmail.com' \
--to=hawkinsw@obs.cr \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).