public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Tweak timeout for testsuite/std/ranges/iota/max_size_type.cc
Date: Sun, 8 Aug 2021 07:56:50 +0100	[thread overview]
Message-ID: <CAH6eHdQHyDN95+7eXngWGr07QfJqQc43FXG0Nmo7HTH5kUpwhw@mail.gmail.com> (raw)
In-Reply-To: <alpine.BSF.2.20.16.2108072239160.55678@arjuna.pair.com>

On Sun, 8 Aug 2021, 03:42 Hans-Peter Nilsson, <hp@bitrange.com> wrote:

> A simulator can easily spend more than 10 minutes running this
> test-case, and the default timeout is at 5 minutes. Better allow
> even slower machines; use 4 as the factor.
>
> Regarding relative runtime numbers (very local; mmixware simulator for
> mmix-knuth-mmixware): test01 and test05 finish momentarily; test02 at
> about 2 minutes, and test03 about 2m30, but test04 itself runs for
> more than 6 minutes and so timed out.
>

Strange, it does fewer iterations than test03. I guess the arithmetic is
slower.


Not sure if it's better to split up this test, as the excessive
> runtime may be unintended, but this seemed simplest.
>
> Ok to commit?
>


Ok, thanks.



> libstdc++-v3:
>         * testsuite/std/ranges/iota/max_size_type.cc: Set
>         dg-timeout-factor to 4.
> ---
>  libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> index 983bdfbdaa6c..a52e8e6231aa 100644
> --- a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> +++ b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> @@ -17,6 +17,7 @@
>
>  // { dg-options "-std=gnu++2a" }
>  // { dg-do run { target c++2a } }
> +// { dg-timeout-factor 4 }
>
>  #include <limits>
>  #include <ranges>
> --
> 2.20.1
>
>

      reply	other threads:[~2021-08-08  6:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  2:42 Hans-Peter Nilsson
2021-08-08  6:56 ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH6eHdQHyDN95+7eXngWGr07QfJqQc43FXG0Nmo7HTH5kUpwhw@mail.gmail.com \
    --to=jwakely.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hp@bitrange.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).