* [PATCH] libstdc++: Tweak timeout for testsuite/std/ranges/iota/max_size_type.cc
@ 2021-08-08 2:42 Hans-Peter Nilsson
2021-08-08 6:56 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Hans-Peter Nilsson @ 2021-08-08 2:42 UTC (permalink / raw)
To: gcc-patches, libstdc++
A simulator can easily spend more than 10 minutes running this
test-case, and the default timeout is at 5 minutes. Better allow
even slower machines; use 4 as the factor.
Regarding relative runtime numbers (very local; mmixware simulator for
mmix-knuth-mmixware): test01 and test05 finish momentarily; test02 at
about 2 minutes, and test03 about 2m30, but test04 itself runs for
more than 6 minutes and so timed out.
Not sure if it's better to split up this test, as the excessive
runtime may be unintended, but this seemed simplest.
Ok to commit?
libstdc++-v3:
* testsuite/std/ranges/iota/max_size_type.cc: Set
dg-timeout-factor to 4.
---
libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
index 983bdfbdaa6c..a52e8e6231aa 100644
--- a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
+++ b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
@@ -17,6 +17,7 @@
// { dg-options "-std=gnu++2a" }
// { dg-do run { target c++2a } }
+// { dg-timeout-factor 4 }
#include <limits>
#include <ranges>
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libstdc++: Tweak timeout for testsuite/std/ranges/iota/max_size_type.cc
2021-08-08 2:42 [PATCH] libstdc++: Tweak timeout for testsuite/std/ranges/iota/max_size_type.cc Hans-Peter Nilsson
@ 2021-08-08 6:56 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2021-08-08 6:56 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: gcc-patches, libstdc++
On Sun, 8 Aug 2021, 03:42 Hans-Peter Nilsson, <hp@bitrange.com> wrote:
> A simulator can easily spend more than 10 minutes running this
> test-case, and the default timeout is at 5 minutes. Better allow
> even slower machines; use 4 as the factor.
>
> Regarding relative runtime numbers (very local; mmixware simulator for
> mmix-knuth-mmixware): test01 and test05 finish momentarily; test02 at
> about 2 minutes, and test03 about 2m30, but test04 itself runs for
> more than 6 minutes and so timed out.
>
Strange, it does fewer iterations than test03. I guess the arithmetic is
slower.
Not sure if it's better to split up this test, as the excessive
> runtime may be unintended, but this seemed simplest.
>
> Ok to commit?
>
Ok, thanks.
> libstdc++-v3:
> * testsuite/std/ranges/iota/max_size_type.cc: Set
> dg-timeout-factor to 4.
> ---
> libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> index 983bdfbdaa6c..a52e8e6231aa 100644
> --- a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> +++ b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> @@ -17,6 +17,7 @@
>
> // { dg-options "-std=gnu++2a" }
> // { dg-do run { target c++2a } }
> +// { dg-timeout-factor 4 }
>
> #include <limits>
> #include <ranges>
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-08 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-08 2:42 [PATCH] libstdc++: Tweak timeout for testsuite/std/ranges/iota/max_size_type.cc Hans-Peter Nilsson
2021-08-08 6:56 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).