public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
* [committed][_GLIBCXX_INLINE_VERSION] Add emul TLS symbol exports
@ 2023-10-29 21:24 François Dumont
  2023-10-30 13:58 ` Jonathan Wakely
  0 siblings, 1 reply; 4+ messages in thread
From: François Dumont @ 2023-10-29 21:24 UTC (permalink / raw)
  To: libstdc++; +Cc: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

libstdc++: [_GLIBCXX_INLINE_VERSION] Add emul TLS symbols

libstdc++-v3/ChangeLog:

     * config/abi/pre/gnu-versioned-namespace.ver: Add missing emul TLS
     symbols.

François

[-- Attachment #2: version_ns_symbols.diff --]
[-- Type: text/x-patch, Size: 532 bytes --]

diff --git a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver
index 9fab8bead15..3140a9628d8 100644
--- a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver
+++ b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver
@@ -78,6 +78,8 @@ GLIBCXX_8.0 {
 
     # thread/mutex/condition_variable/future
     __once_proxy;
+    __emutls_v._ZSt3__811__once_call;
+    __emutls_v._ZSt3__815__once_callable;
 
     # std::__convert_to_v
     _ZNSt3__814__convert_to_v*;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [committed][_GLIBCXX_INLINE_VERSION] Add emul TLS symbol exports
  2023-10-29 21:24 [committed][_GLIBCXX_INLINE_VERSION] Add emul TLS symbol exports François Dumont
@ 2023-10-30 13:58 ` Jonathan Wakely
  2023-10-30 18:06   ` François Dumont
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Wakely @ 2023-10-30 13:58 UTC (permalink / raw)
  To: François Dumont; +Cc: libstdc++, gcc-patches

On Sun, 29 Oct 2023 at 21:25, François Dumont <frs.dumont@gmail.com> wrote:
>
> libstdc++: [_GLIBCXX_INLINE_VERSION] Add emul TLS symbols
>
> libstdc++-v3/ChangeLog:
>
>      * config/abi/pre/gnu-versioned-namespace.ver: Add missing emul TLS
>      symbols.


Please put a comment above the two new lines, the same as in gnu.ver:

# targets using emutls

OK with that change, thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [committed][_GLIBCXX_INLINE_VERSION] Add emul TLS symbol exports
  2023-10-30 13:58 ` Jonathan Wakely
@ 2023-10-30 18:06   ` François Dumont
  2023-10-30 19:13     ` Jonathan Wakely
  0 siblings, 1 reply; 4+ messages in thread
From: François Dumont @ 2023-10-30 18:06 UTC (permalink / raw)
  To: Jonathan Wakely; +Cc: libstdc++, gcc-patches


On 30/10/2023 14:58, Jonathan Wakely wrote:
> On Sun, 29 Oct 2023 at 21:25, François Dumont <frs.dumont@gmail.com> wrote:
>> libstdc++: [_GLIBCXX_INLINE_VERSION] Add emul TLS symbols
>>
>> libstdc++-v3/ChangeLog:
>>
>>       * config/abi/pre/gnu-versioned-namespace.ver: Add missing emul TLS
>>       symbols.
>
> Please put a comment above the two new lines, the same as in gnu.ver:
>
> # targets using emutls
>
> OK with that change, thanks.

It's already committed as it was a trivial change limited to the 
versioned namespace special mode for which I'm maintainer.

Can you confirm you want a new commit just to add this comment ?



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [committed][_GLIBCXX_INLINE_VERSION] Add emul TLS symbol exports
  2023-10-30 18:06   ` François Dumont
@ 2023-10-30 19:13     ` Jonathan Wakely
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Wakely @ 2023-10-30 19:13 UTC (permalink / raw)
  To: François Dumont; +Cc: Jonathan Wakely, libstdc++, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Mon, 30 Oct 2023, 18:07 François Dumont, <frs.dumont@gmail.com> wrote:

>
> On 30/10/2023 14:58, Jonathan Wakely wrote:
> > On Sun, 29 Oct 2023 at 21:25, François Dumont <frs.dumont@gmail.com>
> wrote:
> >> libstdc++: [_GLIBCXX_INLINE_VERSION] Add emul TLS symbols
> >>
> >> libstdc++-v3/ChangeLog:
> >>
> >>       * config/abi/pre/gnu-versioned-namespace.ver: Add missing emul TLS
> >>       symbols.
> >
> > Please put a comment above the two new lines, the same as in gnu.ver:
> >
> > # targets using emutls
> >
> > OK with that change, thanks.
>
> It's already committed as it was a trivial change limited to the
> versioned namespace special mode for which I'm maintainer.
>
> Can you confirm you want a new commit just to add this comment ?
>

Yes please

>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-30 19:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-29 21:24 [committed][_GLIBCXX_INLINE_VERSION] Add emul TLS symbol exports François Dumont
2023-10-30 13:58 ` Jonathan Wakely
2023-10-30 18:06   ` François Dumont
2023-10-30 19:13     ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).