From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Iain Sandoe <iains.gcc@gmail.com>
Subject: Re: [PATCH] libstdc++, testsuite: Correct an init.
Date: Sat, 24 Dec 2022 12:07:25 +0000 [thread overview]
Message-ID: <CAH6eHdR4=Awyb5WKwv6F7C0aOOOJwBV+Jne9L7MCOYVJYDJ9Pg@mail.gmail.com> (raw)
In-Reply-To: <20221224114234.20419-1-iain@sandoe.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On Sat, 24 Dec 2022, 11:43 Iain Sandoe via Libstdc++, <libstdc++@gcc.gnu.org>
wrote:
> Noticed while debugging tz info support on Darwin, unless I miss
> some other reasoning...
> OK for trunk?
>
Doh, thanks. OK for trunk.
Iain
>
> --- 8< ---
>
> in leap_seconds.cc, we are testing to see if the function that
> overrides the default zoneinfo directory has been called. That
> is implemented with a static boolean that needs to be initialized
> to false.
>
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>
> libstdc++-v3/ChangeLog:
>
> * testsuite/std/time/tzdb/leap_seconds.cc: Initialize the
> override_used test var to false.
> ---
> libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> index 82303e8bdf0..2b289436583 100644
> --- a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> +++ b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> @@ -7,7 +7,7 @@
> #include <fstream>
> #include <testsuite_hooks.h>
>
> -static bool override_used = true;
> +static bool override_used = false;
>
> namespace __gnu_cxx
> {
> --
> 2.37.1 (Apple Git-137.1)
>
>
prev parent reply other threads:[~2022-12-24 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 11:42 Iain Sandoe
2022-12-24 12:07 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdR4=Awyb5WKwv6F7C0aOOOJwBV+Jne9L7MCOYVJYDJ9Pg@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=iains.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).