From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++ testsuite: Increase lwg3464.cc timeout factors to 20
Date: Sun, 30 Jan 2022 08:32:08 +0000 [thread overview]
Message-ID: <CAH6eHdRMwDW++Aeg7fmsr3xvOtv7UaWPKQGDX-6m78vxvpJqRw@mail.gmail.com> (raw)
In-Reply-To: <20220130013541.A127620418@pchp3.se.axis.com>
On Sun, 30 Jan 2022, 01:37 Hans-Peter Nilsson via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
> These tests have always been failing for my cris-elf
> autotester running a simulator; they take about 20 minutes
> each, compared to the timeout of 720 seconds, doubled
> because they timed out in another simulator setup.
>
> They are the *only* libstdc++ tests that timeout for my
> setup so I thought this'd be best fixed in the testsuite
> rather than a local timeout setting (in e.g. the baseboard
> file). And, better make it an increase that counts. Or,
> maybe they're actually needlessly excessive?
They are testing behaviour when a counter overflows, so they have to read
that many bytes. Making them do less work would not test that condition.
But there is nothing target-specific in that code, so it should be fine to
disable them for simulators. They're already disabled for LP64 because
overflowing the 64-bit counter would take forever.
I think that would be better than letting them potentially run for 40
minutes even on real hardware.
next prev parent reply other threads:[~2022-01-30 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 1:35 Hans-Peter Nilsson
2022-01-30 8:32 ` Jonathan Wakely [this message]
2022-01-30 16:54 ` [PATCH] libstdc++ testsuite: Don't run lwg3464.cc tests on simulators " Hans-Peter Nilsson
2022-01-30 17:06 ` Jonathan Wakely
2022-01-30 18:05 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdRMwDW++Aeg7fmsr3xvOtv7UaWPKQGDX-6m78vxvpJqRw@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).