From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH 1/4] libstdc++: Add already-accepted <ranges> testcase [PR106320]
Date: Mon, 12 Sep 2022 19:30:30 +0100 [thread overview]
Message-ID: <CAH6eHdS-nwj_Y7nQfLC-Y=eL9dr2Yju4zp2TP-o-r95HqrjVhQ@mail.gmail.com> (raw)
In-Reply-To: <20220912164531.1742034-1-ppalka@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
On Mon, 12 Sep 2022, 17:46 Patrick Palka via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
> Although PR106320 only affected the 10 and 11 branches, and the testcase
> from there was already correctly accepted on trunk and the 12 branch, we
> should also add the testcase to 12/trunk for inter-branch consistency.
>
> Tested on x86_64-pc-linux-gnu, does this look OK for trunk/12?
>
Yes, good idea to add this.
> PR libstdc++/106320
>
> libstdc++-v3/ChangeLog:
>
> * testsuite/std/ranges/adaptors/join.cc (test13): New test.
> ---
> libstdc++-v3/testsuite/std/ranges/adaptors/join.cc | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc
> b/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc
> index 8986f718229..530ab6663b5 100644
> --- a/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc
> +++ b/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc
> @@ -205,6 +205,18 @@ test12()
> }();
> }
>
> +void
> +test13()
> +{
> + // PR libstdc++/106320
> + auto l = std::views::transform([](auto x) {
> + return x | std::views::transform([i=0](auto y) {
> + return y;
> + });
> + });
> + std::vector<std::vector<int>> v{{5, 6, 7}};
> + v | l | std::views::join;
> +}
> int
> main()
> {
> @@ -220,4 +232,5 @@ main()
> test10();
> test11();
> test12();
> + test13();
> }
> --
> 2.37.3.542.gdd3f6c4cae
>
>
prev parent reply other threads:[~2022-09-12 18:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 16:45 Patrick Palka
2022-09-12 16:45 ` [PATCH 2/4] libstdc++: Implement LWG 3569 changes to join_view::_Iterator Patrick Palka
2022-09-13 10:57 ` Jonathan Wakely
2022-09-12 16:45 ` [PATCH 3/4] libstdc++: Implement ranges::chunk_view from P2442R1 Patrick Palka
2022-09-13 11:10 ` Jonathan Wakely
2022-09-12 16:45 ` [PATCH 4/4] libstdc++: Implement ranges::slide_view " Patrick Palka
2022-09-13 11:12 ` Jonathan Wakely
2022-09-12 18:30 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdS-nwj_Y7nQfLC-Y=eL9dr2Yju4zp2TP-o-r95HqrjVhQ@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).