* [PATCH] libstdc++: Correctly call _string_types function
@ 2023-10-04 15:10 Tom Tromey
2023-10-04 15:11 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-10-04 15:10 UTC (permalink / raw)
To: gcc-patches; +Cc: libstdc++, Tom Tromey
flake8 points out that the new call to _string_types from
StdExpAnyPrinter.__init__ is not correct -- it needs to be qualified.
libstdc++-v3/ChangeLog:
* python/libstdcxx/v6/printers.py
(StdExpAnyPrinter.__init__): Qualify call to
_string_types.
---
libstdc++-v3/python/libstdcxx/v6/printers.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py b/libstdc++-v3/python/libstdcxx/v6/printers.py
index 23efbd171ec..9a51f26d8e0 100644
--- a/libstdc++-v3/python/libstdcxx/v6/printers.py
+++ b/libstdc++-v3/python/libstdcxx/v6/printers.py
@@ -1386,7 +1386,7 @@ class StdExpAnyPrinter(SingleObjContainerPrinter):
# FIXME need to expand 'std::string' so that gdb.lookup_type works
if 'std::string' in mgrname:
mgrtypes = []
- for s in _string_types():
+ for s in StdExpAnyPrinter._string_types():
try:
x = re.sub(r"std::string(?!\w)", s, m.group(1))
# The following lookup might raise gdb.error if the
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libstdc++: Correctly call _string_types function
2023-10-04 15:10 [PATCH] libstdc++: Correctly call _string_types function Tom Tromey
@ 2023-10-04 15:11 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2023-10-04 15:11 UTC (permalink / raw)
To: Tom Tromey; +Cc: gcc-patches, libstdc++
On Wed, 4 Oct 2023 at 16:10, Tom Tromey <tromey@adacore.com> wrote:
>
> flake8 points out that the new call to _string_types from
> StdExpAnyPrinter.__init__ is not correct -- it needs to be qualified.
OK, thanks.
>
> libstdc++-v3/ChangeLog:
>
> * python/libstdcxx/v6/printers.py
> (StdExpAnyPrinter.__init__): Qualify call to
> _string_types.
> ---
> libstdc++-v3/python/libstdcxx/v6/printers.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py b/libstdc++-v3/python/libstdcxx/v6/printers.py
> index 23efbd171ec..9a51f26d8e0 100644
> --- a/libstdc++-v3/python/libstdcxx/v6/printers.py
> +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py
> @@ -1386,7 +1386,7 @@ class StdExpAnyPrinter(SingleObjContainerPrinter):
> # FIXME need to expand 'std::string' so that gdb.lookup_type works
> if 'std::string' in mgrname:
> mgrtypes = []
> - for s in _string_types():
> + for s in StdExpAnyPrinter._string_types():
> try:
> x = re.sub(r"std::string(?!\w)", s, m.group(1))
> # The following lookup might raise gdb.error if the
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-04 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-04 15:10 [PATCH] libstdc++: Correctly call _string_types function Tom Tromey
2023-10-04 15:11 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).