From: xndcn <xndchn@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Xi Ruoyao <xry111@xry111.site>,
"H.J. Lu" <hjl.tools@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: [PING][PATCH] libstdc++: atomic: Add missing clear_padding in __atomic_float constructor
Date: Mon, 25 Mar 2024 23:42:06 +0800 [thread overview]
Message-ID: <CAJ=gGT2wtC+Em1Uq31f8gtmtG57W+u751wmiHccFt7t2Gf4E0Q@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=++PTkv_rtALwhBcNq3jS0999SQqSYeKykxMGYszsdCg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
Wow, thank you all, you guys!
在 2024年3月14日星期四,Jonathan Wakely <jwakely@redhat.com> 写道:
> On Fri, 16 Feb 2024 at 15:15, Jonathan Wakely wrote:
> >
> > On Fri, 16 Feb 2024 at 14:10, Jakub Jelinek wrote:
> > >
> > > On Fri, Feb 16, 2024 at 01:51:54PM +0000, Jonathan Wakely wrote:
> > > > Ah, although __atomic_compare_exchange only takes pointers, the
> > > > compiler replaces that with a call to __atomic_compare_exchange_n
> > > > which takes the newval by value, which presumably uses an 80-bit FP
> > > > register and so the padding bits become indeterminate again.
> > >
> > > __atomic_compare_exchange_n only works with integers, so I guess
> > > it is doing VIEW_CONVERT_EXPR (aka union-style type punning) on the
> > > argument.
> > >
> > > Do you have preprocessed source for the testcase?
> >
> > Sent offlist.
>
> Jakub fixed the compiler, so I've pushed the attached patch now.
>
> Tested x86_64-linux.
>
prev parent reply other threads:[~2024-03-25 15:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJ=gGT3=TCsF2GcsawmbOReDjwVPmxpSLw1_CTZX5NE6HUtu+g@mail.gmail.com>
[not found] ` <CAMe9rOrm4=d5xkHeocOFNWf4=vUfwc_bzp4_zUt8j8+apcrWoA@mail.gmail.com>
[not found] ` <CAJ=gGT1LwAeKF6B5eNFBdKXzeK9Z1ubAwH-ykS_2X2Fc9t7-Ww@mail.gmail.com>
2024-01-16 10:12 ` [PATCH] " Xi Ruoyao
2024-01-16 16:16 ` xndcn
2024-01-24 15:53 ` xndcn
2024-01-30 16:08 ` [PING][PATCH] " xndcn
2024-01-30 16:31 ` [PATCH] " Jonathan Wakely
2024-01-30 16:34 ` Jonathan Wakely
2024-01-30 16:50 ` Jakub Jelinek
2024-01-31 17:19 ` xndcn
2024-02-01 13:54 ` Jonathan Wakely
2024-02-02 16:52 ` xndcn
2024-02-16 12:38 ` Jonathan Wakely
2024-02-16 13:51 ` Jonathan Wakely
2024-02-16 14:10 ` Jakub Jelinek
2024-02-16 15:15 ` Jonathan Wakely
2024-03-14 15:13 ` Jonathan Wakely
2024-03-25 15:42 ` xndcn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=gGT2wtC+Em1Uq31f8gtmtG57W+u751wmiHccFt7t2Gf4E0Q@mail.gmail.com' \
--to=xndchn@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).