From: Pranav Kant <prka@google.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
Stephan Bergmann <sbergman@redhat.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Define std::numeric_limits<_FloatNN> before C++23
Date: Wed, 4 Oct 2023 11:21:05 -0700 [thread overview]
Message-ID: <CAPvNhs+jWk=o1bHEKYzWNOjaaXCHYGNT=UMzvwFY8yJ_dyZfzg@mail.gmail.com> (raw)
In-Reply-To: <CAPvNhs+Jks3abbUtE6TcWsSeRNyi+FRG8=_xsLGEZxakVDq5Ew@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
I have reverted the change upstream (
https://github.com/llvm/llvm-project/commit/7d21086d0ca4a680e96e0f4cd3e2597ebe027a48
).
On Wed, Oct 4, 2023 at 10:00 AM Pranav Kant <prka@google.com> wrote:
> I will revert the commit while I work on this. Thanks for the pointers.
>
> On Wed, Oct 4, 2023 at 9:57 AM Jakub Jelinek <jakub@redhat.com> wrote:
>
>> On Wed, Oct 04, 2023 at 09:47:34AM -0700, Pranav Kant wrote:
>> > Thanks for bringing this to my attention. I am working on a fix. Will
>> keep
>> > this thread posted.
>> >
>> > Clang *does* define this macro only when float128 type is available. But
>> > the problem seems to be that clang doesn't define _Float128 alias type
>> > which is what's being used here. It only defines __float128 type.
>> Should be
>> > easy to fix.
>>
>> _Float128 (and other _FloatNN types) are standard C23 and C++23 types,
>> they certainly can't be simple aliases to __float128 or other similar
>> types.
>> In C++ they mangle differently, have significantly different behavior in
>> lots of different language details.
>> So, you need to implement the https://wg21.link/P1467R9 paper, rather
>> than
>> doing quick hacks.
>>
>> Jakub
>>
>>
prev parent reply other threads:[~2023-10-04 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 20:32 Jonathan Wakely
2023-10-04 15:54 ` Stephan Bergmann
2023-10-04 15:56 ` Jonathan Wakely
2023-10-04 16:47 ` Pranav Kant
2023-10-04 16:57 ` Jakub Jelinek
2023-10-04 17:00 ` Pranav Kant
2023-10-04 18:21 ` Pranav Kant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPvNhs+jWk=o1bHEKYzWNOjaaXCHYGNT=UMzvwFY8yJ_dyZfzg@mail.gmail.com' \
--to=prka@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=sbergman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).