public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Keir <Paul.Keir@uws.ac.uk>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Fix compare_three_way for constexpr and Clang
Date: Mon, 11 Oct 2021 14:33:19 +0000	[thread overview]
Message-ID: <VI1PR0102MB31970918580F518963367920A4B59@VI1PR0102MB3197.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <VI1PR0102MB3197B7287CCB33BC83993852A4CF9@VI1PR0102MB3197.eurprd01.prod.exchangelabs.com>

*ping*

________________________________________
From: Paul Keir <Paul.Keir@uws.ac.uk>
Sent: 03 September 2021 11:31
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Fix compare_three_way for constexpr and Clang

*ping*

________________________________________
From: Paul Keir <Paul.Keir@uws.ac.uk>
Sent: 20 August 2021 21:17
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org
Subject: [PATCH] libstdc++: Fix compare_three_way for constexpr and Clang

Hi,

The current compare_three_way implementation makes provision for constant evaluation contexts (avoiding reinterpret_cast etc.), but the approach fails with Clang; when it compares two const volatile void pointers: "comparison between unequal pointers to void has unspecified result". I include a fix and test.

Could someone commit the attached patch for me?

Thanks,
Paul


Please consider the environment and think before you print.

The University of the West of Scotland is a registered Scottish charity. Charity number SC002520.

This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender.

Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the University of the West of Scotland.

As a public body, the University of the West of Scotland may be required to make available emails as well as other written forms of information as a result of a request made under the Freedom of Information (Scotland) Act 2002.

  reply	other threads:[~2021-10-11 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 20:17 Paul Keir
2021-09-03 10:31 ` Paul Keir
2021-10-11 14:33   ` Paul Keir [this message]
2021-10-11 19:48 ` Jonathan Wakely
2021-10-11 21:04   ` Jonathan Wakely
2021-10-13 21:37     ` Paul Keir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0102MB31970918580F518963367920A4B59@VI1PR0102MB3197.eurprd01.prod.exchangelabs.com \
    --to=paul.keir@uws.ac.uk \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).