From: Jonathan Wakely <jwakely@redhat.com>
To: Paul Keir <Paul.Keir@uws.ac.uk>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Fix compare_three_way for constexpr and Clang
Date: Mon, 11 Oct 2021 22:04:03 +0100 [thread overview]
Message-ID: <CACb0b4kqdFub1h_1wYzKnmAhaYTcCZPXreMczV_U0ODfczWBFw@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4n_2Yr-xhYQ2HHFSai1m910VLT2oMDRK1i6Lr36rwsJWg@mail.gmail.com>
On Mon, 11 Oct 2021 at 20:48, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On Fri, 20 Aug 2021 at 21:19, Paul Keir wrote:
> >
> > Hi,
> >
> > The current compare_three_way implementation makes provision for constant evaluation contexts (avoiding reinterpret_cast etc.), but the approach fails with Clang; when it compares two const volatile void pointers: "comparison between unequal pointers to void has unspecified result". I include a fix and test.
> >
> > Could someone commit the attached patch for me?
>
> Sorry for dropping the ball on this again. I've applied the patch
> locally and I'm testing it now. Unless I'm mistaken, you do not have a
> copyright assignment on file with the FSF, is that right? Are you able
> to certify that you have the right to submit this to GCC, as described
> at https://gcc.gnu.org/dco.html ?
P.S. patches should not touch the ChangeLog file. It was always wrong,
because it usually makes the patch fail to apply. Since we moved to
Git the ChangeLog files are automatically generated from the Git
commits anyway, so are never touched as part of the commit. The
changelog entry is still needed, but should be in the Git commit
message not as a patch against the actual ChangeLog file.
>
> Also, if GCC is failing to diagnose the invalid comparisons here then
> that should be reported to bugzilla as a c++ "accepts-invalid" bug.
next prev parent reply other threads:[~2021-10-11 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 20:17 Paul Keir
2021-09-03 10:31 ` Paul Keir
2021-10-11 14:33 ` Paul Keir
2021-10-11 19:48 ` Jonathan Wakely
2021-10-11 21:04 ` Jonathan Wakely [this message]
2021-10-13 21:37 ` Paul Keir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4kqdFub1h_1wYzKnmAhaYTcCZPXreMczV_U0ODfczWBFw@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=Paul.Keir@uws.ac.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).