public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Seija Kijin <doremylover456@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Fixing Error: invalid type argument of unary '*' (have 'int')
Date: Wed, 12 Oct 2022 12:25:16 +0100	[thread overview]
Message-ID: <Y0akHFAhXPdOr0SD@redhat.com> (raw)
In-Reply-To: <CAOfV4GcBnEByQGw8E4GeNpifU+T-bbRGXy09c91HCpOGx_OTeA@mail.gmail.com>

On 04/08/22 12:54 -0400, Seija Kijin wrote:
>Had an error compiling tiny-cuda-nn using gcc 12.1. With this minor
>patch, I recompiled and the build succeeded.

This looks like a bug in the cuda compiler then. The libstdc++ code is
correct.

N.B. libstdc++ patches need to be CC'd to the libstdc++ list, or they
won't get reviewed.


>No behavioral change.
>---
> libstdc++-v3/include/bits/locale_facets_nonio.tcc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/libstdc++-v3/include/bits/locale_facets_nonio.tcc
>b/libstdc++-v3/include/bits/locale_facets_nonio.tcc
>index 17a2c8d4486e..fc35a9e693e7 100644
>--- a/libstdc++-v3/include/bits/locale_facets_nonio.tcc
>+++ b/libstdc++-v3/include/bits/locale_facets_nonio.tcc
>@@ -1474,8 +1474,8 @@ _GLIBCXX_END_NAMESPACE_LDBL_OR_CXX11
>       // calls.  So e.g. if __fmt is "%p %I:%M:%S", we can't handle it
>       // properly, because we first handle the %p am/pm specifier and only
>       // later the 12-hour format specifier.
>-      if ((void*)(this->*(&time_get::do_get)) == (void*)(&time_get::do_get))
>- __use_state = true;
>+      if ((void*)(this->*(&time_get::do_get)) == (&time_get::do_get))
>+        __use_state = true;
> #pragma GCC diagnostic pop
> #endif
>       __time_get_state __state = __time_get_state();


           reply	other threads:[~2022-10-12 11:25 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CAOfV4GcBnEByQGw8E4GeNpifU+T-bbRGXy09c91HCpOGx_OTeA@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0akHFAhXPdOr0SD@redhat.com \
    --to=jwakely@redhat.com \
    --cc=doremylover456@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).