* [committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]
@ 2021-09-17 19:45 Jonathan Wakely
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Wakely @ 2021-09-17 19:45 UTC (permalink / raw)
To: libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
Also rename the test so it actually runs.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/102270
* include/std/tuple (_Tuple_impl): Add constexpr to constructor
missed in previous patch.
* testsuite/20_util/tuple/cons/102270.C: Moved to...
* testsuite/20_util/tuple/cons/102270.cc: ...here.
* testsuite/util/testsuite_allocator.h (SimpleAllocator): Add
constexpr to constructor so it can be used for C++20 tests.
Tested powerpc64le-linux. Committed to trunk.
git mailpatch 42eff613d0c10f88dc7a44b14981876401a09981
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 2448 bytes --]
commit 1fa2c5a695bb962ffcf8abed49f69cdcc59d0e61
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Sep 17 12:27:02 2021
libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]
Also rename the test so it actually runs.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/102270
* include/std/tuple (_Tuple_impl): Add constexpr to constructor
missed in previous patch.
* testsuite/20_util/tuple/cons/102270.C: Moved to...
* testsuite/20_util/tuple/cons/102270.cc: ...here.
* testsuite/util/testsuite_allocator.h (SimpleAllocator): Add
constexpr to constructor so it can be used for C++20 tests.
diff --git a/libstdc++-v3/include/std/tuple b/libstdc++-v3/include/std/tuple
index 6f0dc6346e1..120c80a2b78 100644
--- a/libstdc++-v3/include/std/tuple
+++ b/libstdc++-v3/include/std/tuple
@@ -330,6 +330,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
{ }
template<typename _Alloc>
+ _GLIBCXX20_CONSTEXPR
_Tuple_impl(allocator_arg_t __tag, const _Alloc& __a,
const _Head& __head, const _Tail&... __tail)
: _Inherited(__tag, __a, __tail...),
diff --git a/libstdc++-v3/testsuite/20_util/tuple/cons/102270.C b/libstdc++-v3/testsuite/20_util/tuple/cons/102270.cc
similarity index 95%
rename from libstdc++-v3/testsuite/20_util/tuple/cons/102270.C
rename to libstdc++-v3/testsuite/20_util/tuple/cons/102270.cc
index 998329817c7..5500cacab6d 100644
--- a/libstdc++-v3/testsuite/20_util/tuple/cons/102270.C
+++ b/libstdc++-v3/testsuite/20_util/tuple/cons/102270.cc
@@ -56,6 +56,9 @@ constexpr bool construct_using_allocator()
std::tuple<X1a, X1a, X1b, X1b> t1a1b(std::allocator_arg, a, 1, i, 1, i);
+ const int c = 0;
+ std::tuple<int, int> tii(std::allocator_arg, a, c, c);
+
return true;
}
static_assert( construct_using_allocator() );
diff --git a/libstdc++-v3/testsuite/util/testsuite_allocator.h b/libstdc++-v3/testsuite/util/testsuite_allocator.h
index 1f7912ea6eb..b5b402858a6 100644
--- a/libstdc++-v3/testsuite/util/testsuite_allocator.h
+++ b/libstdc++-v3/testsuite/util/testsuite_allocator.h
@@ -514,7 +514,7 @@ namespace __gnu_test
{
typedef Tp value_type;
- SimpleAllocator() noexcept { }
+ constexpr SimpleAllocator() noexcept { }
template <class T>
SimpleAllocator(const SimpleAllocator<T>&) { }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]
2021-09-17 19:47 ` [committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270] Jonathan Wakely
@ 2021-09-17 19:48 ` Jonathan Wakely
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Wakely @ 2021-09-17 19:48 UTC (permalink / raw)
To: libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On 17/09/21 20:47 +0100, Jonathan Wakely wrote:
>On 17/09/21 12:25 +0100, Jonathan Wakely wrote:
>>On 16/09/21 23:07 +0100, Jonathan Wakely wrote:
>>>Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
>>>
>>>libstdc++-v3/ChangeLog:
>>>
>>> PR libstdc++/102270
>>> * include/std/tuple (_Head_base, _Tuple_impl): Add
>>> _GLIBCXX20_CONSTEXPR to allocator-extended constructors.
>>> (tuple<>::swap(tuple&)): Add _GLIBCXX20_CONSTEXPR.
>>> * testsuite/20_util/tuple/cons/102270.C: New test.
>>
>>Oops, this test has a .C extension, and so doesn't actually run (and
>>if I rename it to 102270.cc it fails).
>>
>>Fix incoming ...
>
>Fixed at r12-3637.
>
>Tested x86_64-linux. Committed to trunk.
With the patch attached this time ...
[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 2448 bytes --]
commit 1fa2c5a695bb962ffcf8abed49f69cdcc59d0e61
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Sep 17 12:27:02 2021
libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]
Also rename the test so it actually runs.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/102270
* include/std/tuple (_Tuple_impl): Add constexpr to constructor
missed in previous patch.
* testsuite/20_util/tuple/cons/102270.C: Moved to...
* testsuite/20_util/tuple/cons/102270.cc: ...here.
* testsuite/util/testsuite_allocator.h (SimpleAllocator): Add
constexpr to constructor so it can be used for C++20 tests.
diff --git a/libstdc++-v3/include/std/tuple b/libstdc++-v3/include/std/tuple
index 6f0dc6346e1..120c80a2b78 100644
--- a/libstdc++-v3/include/std/tuple
+++ b/libstdc++-v3/include/std/tuple
@@ -330,6 +330,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
{ }
template<typename _Alloc>
+ _GLIBCXX20_CONSTEXPR
_Tuple_impl(allocator_arg_t __tag, const _Alloc& __a,
const _Head& __head, const _Tail&... __tail)
: _Inherited(__tag, __a, __tail...),
diff --git a/libstdc++-v3/testsuite/20_util/tuple/cons/102270.C b/libstdc++-v3/testsuite/20_util/tuple/cons/102270.cc
similarity index 95%
rename from libstdc++-v3/testsuite/20_util/tuple/cons/102270.C
rename to libstdc++-v3/testsuite/20_util/tuple/cons/102270.cc
index 998329817c7..5500cacab6d 100644
--- a/libstdc++-v3/testsuite/20_util/tuple/cons/102270.C
+++ b/libstdc++-v3/testsuite/20_util/tuple/cons/102270.cc
@@ -56,6 +56,9 @@ constexpr bool construct_using_allocator()
std::tuple<X1a, X1a, X1b, X1b> t1a1b(std::allocator_arg, a, 1, i, 1, i);
+ const int c = 0;
+ std::tuple<int, int> tii(std::allocator_arg, a, c, c);
+
return true;
}
static_assert( construct_using_allocator() );
diff --git a/libstdc++-v3/testsuite/util/testsuite_allocator.h b/libstdc++-v3/testsuite/util/testsuite_allocator.h
index 1f7912ea6eb..b5b402858a6 100644
--- a/libstdc++-v3/testsuite/util/testsuite_allocator.h
+++ b/libstdc++-v3/testsuite/util/testsuite_allocator.h
@@ -514,7 +514,7 @@ namespace __gnu_test
{
typedef Tp value_type;
- SimpleAllocator() noexcept { }
+ constexpr SimpleAllocator() noexcept { }
template <class T>
SimpleAllocator(const SimpleAllocator<T>&) { }
^ permalink raw reply [flat|nested] 3+ messages in thread
* [committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]
2021-09-17 11:25 ` Jonathan Wakely
@ 2021-09-17 19:47 ` Jonathan Wakely
2021-09-17 19:48 ` Jonathan Wakely
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Wakely @ 2021-09-17 19:47 UTC (permalink / raw)
To: libstdc++, gcc-patches
On 17/09/21 12:25 +0100, Jonathan Wakely wrote:
>On 16/09/21 23:07 +0100, Jonathan Wakely wrote:
>>Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
>>
>>libstdc++-v3/ChangeLog:
>>
>> PR libstdc++/102270
>> * include/std/tuple (_Head_base, _Tuple_impl): Add
>> _GLIBCXX20_CONSTEXPR to allocator-extended constructors.
>> (tuple<>::swap(tuple&)): Add _GLIBCXX20_CONSTEXPR.
>> * testsuite/20_util/tuple/cons/102270.C: New test.
>
>Oops, this test has a .C extension, and so doesn't actually run (and
>if I rename it to 102270.cc it fails).
>
>Fix incoming ...
Fixed at r12-3637.
Tested x86_64-linux. Committed to trunk.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-17 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 19:45 [committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270] Jonathan Wakely
-- strict thread matches above, loose matches on Subject: below --
2021-09-16 22:07 [committed] libstdc++: Add missing 'constexpr' to std::tuple [PR102270] Jonathan Wakely
2021-09-17 11:25 ` Jonathan Wakely
2021-09-17 19:47 ` [committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270] Jonathan Wakely
2021-09-17 19:48 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).