From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Patrick Palka <ppalka@redhat.com>,
libstdc++ <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] libstdc++: case-sensitivity in hexfloat std::from_chars [PR105441]
Date: Mon, 2 May 2022 07:05:50 +0200 [thread overview]
Message-ID: <Ym9mrjkv++bzkAf9@tucnak> (raw)
In-Reply-To: <CACb0b4ki18HtgBihY6g5BkvFkaXmQXNh2_RT0VH3ufzO2hpHvA@mail.gmail.com>
On Sun, May 01, 2022 at 08:09:05PM +0100, Jonathan Wakely via Gcc-patches wrote:
> On Sun, 1 May 2022 at 19:22, Patrick Palka via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
> >
> > The hexfloat parser for binary32/64 added in r12-6645-gcc3bf3404e4b1c
> > overlooked that the exponent part can also begin with an uppercase 'P'.
> >
> > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/11, and possibly the
> > 12 branch now for 12.1?
>
> OK for trunk, and as it's a regression since gcc-11 I'd recommend
> release manager approval for 12.1 as well, but it's the RMs call.
Ok for 12.1.
> > PR libstdc++/105441
> >
> > libstdc++-v3/ChangeLog:
> >
> > * src/c++17/floating_from_chars.cc (__floating_from_chars_hex):
> > Also accept 'P' as the start of the exponent.
> > * testsuite/20_util/from_chars/7.cc: Add corresponding testcase.
Jakub
prev parent reply other threads:[~2022-05-02 5:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 18:21 Patrick Palka
2022-05-01 18:21 ` [PATCH 2/2] libstdc++: Don't use std::tolower in <charconv> [PR103911] Patrick Palka
2022-05-01 19:07 ` Jonathan Wakely
2022-05-01 19:09 ` [PATCH 1/2] libstdc++: case-sensitivity in hexfloat std::from_chars [PR105441] Jonathan Wakely
2022-05-02 5:05 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym9mrjkv++bzkAf9@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).