public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR 107189 Remove useless _Alloc_node
Date: Wed, 4 Jan 2023 22:13:17 +0100	[thread overview]
Message-ID: <e127f027-8bb6-7b1a-0872-46fc09e47647@gmail.com> (raw)
In-Reply-To: <7a266d31-cf97-6143-d930-6020bc4ed102@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Still no chance to review ?

On 14/11/22 18:56, François Dumont wrote:
> Gentle reminder.
>
> Sorry if I should have committed it as trivial but I cannot do it 
> anymore now that I asked :-)
>
>
> On 12/10/22 22:18, François Dumont wrote:
>> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]
>>
>>     libstdc++-v3/ChangeLog:
>>
>>             PR libstdc++/107189
>>             * include/bits/stl_tree.h 
>> (_Rb_tree<>::_M_insert_range_equal): Remove
>>             unused _Alloc_node instance.
>>
>> Ok to commit ?
>>
>> François
>
>

[-- Attachment #2: pr107189.patch --]
[-- Type: text/x-patch, Size: 510 bytes --]

diff --git a/libstdc++-v3/include/bits/stl_tree.h b/libstdc++-v3/include/bits/stl_tree.h
index a4de6141765..33d25089a1d 100644
--- a/libstdc++-v3/include/bits/stl_tree.h
+++ b/libstdc++-v3/include/bits/stl_tree.h
@@ -1123,7 +1123,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 	__enable_if_t<!__same_value_type<_InputIterator>::value>
 	_M_insert_range_equal(_InputIterator __first, _InputIterator __last)
 	{
-	  _Alloc_node __an(*this);
 	  for (; __first != __last; ++__first)
 	    _M_emplace_equal(*__first);
 	}

  reply	other threads:[~2023-01-04 21:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 20:18 François Dumont
2022-11-14 17:56 ` François Dumont
2023-01-04 21:13   ` François Dumont [this message]
2023-01-12 12:01     ` Jonathan Wakely
2023-01-12 12:02       ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e127f027-8bb6-7b1a-0872-46fc09e47647@gmail.com \
    --to=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).