From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR 107189 Remove useless _Alloc_node
Date: Thu, 12 Jan 2023 12:02:06 +0000 [thread overview]
Message-ID: <CACb0b4moWUfHyimxL3K5GEy9gCfv60J+YVE=7+q54WQ0EL6q_g@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4mPfE3x=zTDXqd=sJ-2PzXHzQKJZFw+H33jr0qE+ZQJkQ@mail.gmail.com>
On Thu, 12 Jan 2023 at 12:01, Jonathan Wakely wrote:
>
> OK for trunk, sorry for not getting to it sooner.
P.S. I do think this one would have been OK to commit as obvious,
since it's just removing an unused variable and so has no effect on
anything.
>
> On Wed, 4 Jan 2023 at 21:13, François Dumont via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
> >
> > Still no chance to review ?
> >
> > On 14/11/22 18:56, François Dumont wrote:
> > > Gentle reminder.
> > >
> > > Sorry if I should have committed it as trivial but I cannot do it
> > > anymore now that I asked :-)
> > >
> > >
> > > On 12/10/22 22:18, François Dumont wrote:
> > >> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]
> > >>
> > >> libstdc++-v3/ChangeLog:
> > >>
> > >> PR libstdc++/107189
> > >> * include/bits/stl_tree.h
> > >> (_Rb_tree<>::_M_insert_range_equal): Remove
> > >> unused _Alloc_node instance.
> > >>
> > >> Ok to commit ?
> > >>
> > >> François
> > >
> > >
prev parent reply other threads:[~2023-01-12 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 20:18 François Dumont
2022-11-14 17:56 ` François Dumont
2023-01-04 21:13 ` François Dumont
2023-01-12 12:01 ` Jonathan Wakely
2023-01-12 12:02 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4moWUfHyimxL3K5GEy9gCfv60J+YVE=7+q54WQ0EL6q_g@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).