From: Xi Ruoyao <xry111@xry111.site>
To: Ken Matsui <kmatsui@cs.washington.edu>,
Jonathan Wakely <jwakely@redhat.com>
Cc: Ken Matsui <kmatsui@gcc.gnu.org>,
gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v2 2/2] libstdc++: use new built-in trait __is_scalar for std::is_scalar
Date: Thu, 13 Jul 2023 02:56:26 +0800 [thread overview]
Message-ID: <e53224cec4725d8312e7013db136f53f9294b892.camel@xry111.site> (raw)
In-Reply-To: <CAML+3pV0sCoQCu4MyODZ_rCf2ht6LjzStZkTtn=q=12+SeqY5g@mail.gmail.com>
On Wed, 2023-07-12 at 11:32 -0700, Ken Matsui via Gcc-patches wrote:
> > conditional on the front-end change being committed first of course
>
> Does this mean we want to commit this [2/2] patch before committing
> the [1/2] patch in this case?
No, this mean you should get 1/2 reviewed and committed first.
> Also, can I tweak the commit message without being approved again,
> such as attaching the benchmark result?
Yes, as long as the ChangeLog is still correct (the Git hook will reject
a push with wrong ChangeLog format anyway).
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-07-12 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 9:13 [PATCH 1/2] c++, libstdc++: implement __is_scalar built-in trait Ken Matsui
2023-07-03 9:13 ` [PATCH 2/2] libstdc++: use new built-in trait __is_scalar for std::is_scalar Ken Matsui
2023-07-03 10:00 ` [PATCH 1/2] c++, libstdc++: implement __is_scalar built-in trait Ken Matsui
2023-07-08 4:45 ` [PATCH v2 " Ken Matsui
2023-07-08 4:45 ` [PATCH v2 2/2] libstdc++: use new built-in trait __is_scalar for std::is_scalar Ken Matsui
2023-07-12 9:50 ` Jonathan Wakely
2023-07-12 18:32 ` Ken Matsui
2023-07-12 18:56 ` Xi Ruoyao [this message]
2023-07-12 19:06 ` Ken Matsui
2023-07-12 19:23 ` Jonathan Wakely
2023-07-12 19:35 ` Ken Matsui
2023-09-04 15:00 ` [PING][PATCH v2 1/2] c++, libstdc++: implement __is_scalar built-in trait Ken Matsui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e53224cec4725d8312e7013db136f53f9294b892.camel@xry111.site \
--to=xry111@xry111.site \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=kmatsui@cs.washington.edu \
--cc=kmatsui@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).