From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Reduce output of 'make check'
Date: Thu, 7 Sep 2023 19:29:35 +0200 [thread overview]
Message-ID: <f3771170-6735-cc0a-c2cf-2623beae57e6@gmail.com> (raw)
In-Reply-To: <20230907133202.1013843-1-jwakely@redhat.com>
+1 for this cleanup, thanks.
Sorry to troll but I noticed another annoying recent behavior. Maybe the
one who did it will recognize himself and will be willing to find a
solution :-)
When I create a testsuite_files file with 1 test case I have the
following output:
Running
/home/fdumont/dev/gcc/git/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp
...
=== libstdc++ Summary ===
# of expected passes 6
It should be 2. There are 4 additional tests coming from
experimental/simd folder.
I guess they are automatically added for good reasons. But it would be
great to add those only if there is no testsuite_files.
On 07/09/2023 15:31, Jonathan Wakely via Libstdc++ wrote:
> Any objections to this change?
>
> -- >8 --
>
> This removes the 39 lines of shell commands that get echoed when
> starting the testsuite. The fact that near the end of that output it
> prints `echo "WARNING: could not find \`runtest'" 1>&2; :;` makes it
> look like that warning is actually being shown the the user.
>
> Suppress echoing the recipe, so that users only see the actual output
> from the testsuite, not the makefile recipe as well.
>
> libstdc++-v3/ChangeLog:
>
> * testsuite/Makefile.am (check-DEJAGNU): Use @ in recipe.
> * testsuite/Makefile.in: Regenerate.
> ---
> libstdc++-v3/testsuite/Makefile.am | 2 +-
> libstdc++-v3/testsuite/Makefile.in | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libstdc++-v3/testsuite/Makefile.am b/libstdc++-v3/testsuite/Makefile.am
> index 7adc5318192..4cee585fd8e 100644
> --- a/libstdc++-v3/testsuite/Makefile.am
> +++ b/libstdc++-v3/testsuite/Makefile.am
> @@ -117,7 +117,7 @@ $(check_DEJAGNU_normal_targets): check-DEJAGNUnormal%: normal%/site.exp
>
> # Run the testsuite in normal mode.
> check-DEJAGNU $(check_DEJAGNU_normal_targets): check-DEJAGNU%: site.exp
> - $(if $*,@)AR="$(AR)"; export AR; \
> + @$(if $*,@)AR="$(AR)"; export AR; \
> RANLIB="$(RANLIB)"; export RANLIB; \
> if [ -z "$*" ] && [ -n "$(filter -j%, $(MFLAGS))" ]; then \
> rm -rf normal-parallel || true; \
>
next prev parent reply other threads:[~2023-09-07 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 13:31 Jonathan Wakely
2023-09-07 17:29 ` François Dumont [this message]
2023-09-08 2:15 ` Eric Gallager
2023-09-08 10:30 ` Jonathan Wakely
2023-09-08 12:14 ` Eric Gallager
2023-09-08 12:18 ` Jonathan Wakely
2023-09-08 17:06 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3771170-6735-cc0a-c2cf-2623beae57e6@gmail.com \
--to=frs.dumont@gmail.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).