From: Alexey Lapshin <alexey.lapshin@espressif.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Cc: "jwakely@redhat.com" <jwakely@redhat.com>, "hp@axis.com" <hp@axis.com>
Subject: Re: [PATCH] libbacktrace: Fix unconditional -Werror
Date: Fri, 8 Sep 2023 09:48:50 +0000 [thread overview]
Message-ID: <f5c0649ac7ef0acb685a0c47d82acf069dd2d229.camel@espressif.com> (raw)
In-Reply-To: <0784b8c8a8149b672e01ad9da657f6cbf9df7227.camel@espressif.com>
Added to CC: jwakely@redhat.com, hp@axis.com
On Fri, 2023-09-08 at 12:39 +0400, Alexey Lapshin wrote:
> -Werror flag should depend on --enable-werror configure option
>
> ---
> libstdc++-v3/src/libbacktrace/Makefile.am | 2 +-
> libstdc++-v3/src/libbacktrace/Makefile.in | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libstdc++-v3/src/libbacktrace/Makefile.am b/libstdc++-v3/src/libbacktrace/Makefile.am
> index 9abf9dd64a1..27c1ea570e0 100644
> --- a/libstdc++-v3/src/libbacktrace/Makefile.am
> +++ b/libstdc++-v3/src/libbacktrace/Makefile.am
> @@ -45,7 +45,7 @@ libstdc___libbacktrace_la_CPPFLAGS = \
> $(BACKTRACE_CPPFLAGS)
>
> WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
> - -Wcast-qual -Werror
> + -Wcast-qual
> C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wno-unused-but-set-variable
> CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter
> AM_CFLAGS = $(C_WARN_FLAGS)
> diff --git a/libstdc++-v3/src/libbacktrace/Makefile.in b/libstdc++-v3/src/libbacktrace/Makefile.in
> index 1c1242d8827..b78c8443751 100644
> --- a/libstdc++-v3/src/libbacktrace/Makefile.in
> +++ b/libstdc++-v3/src/libbacktrace/Makefile.in
> @@ -368,7 +368,7 @@ VTV_CXXFLAGS = @VTV_CXXFLAGS@
> VTV_CXXLINKFLAGS = @VTV_CXXLINKFLAGS@
> VTV_PCH_CXXFLAGS = @VTV_PCH_CXXFLAGS@
> WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
> - -Wcast-qual -Werror
> + -Wcast-qual
>
> XMLCATALOG = @XMLCATALOG@
> XMLLINT = @XMLLINT@
next prev parent reply other threads:[~2023-09-08 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 8:39 Alexey Lapshin
2023-09-08 9:48 ` Alexey Lapshin [this message]
2023-09-08 10:10 ` Jonathan Wakely
2023-09-08 17:05 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5c0649ac7ef0acb685a0c47d82acf069dd2d229.camel@espressif.com \
--to=alexey.lapshin@espressif.com \
--cc=hp@axis.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).