From: Jonathan Wakely <jwakely@redhat.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Alexey Lapshin <alexey.lapshin@espressif.com>,
"libstdc++" <libstdc++@gcc.gnu.org>,
Hans-Peter Nilsson <hp@axis.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libbacktrace: Fix unconditional -Werror
Date: Fri, 8 Sep 2023 18:05:36 +0100 [thread overview]
Message-ID: <CACb0b4msJvQVYqrCHVvbG6S19rLUSqerwG_7te1_RJL3Dxrz2Q@mail.gmail.com> (raw)
In-Reply-To: <CAH6eHdRO4wiRF571C11AhigKxmUqNf0KWx6AMt+4hYp3yUYG5A@mail.gmail.com>
On Fri, 8 Sept 2023 at 11:10, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>
> The patch looks good, thanks. I noticed the unconditional -Werror the other day when testing a build on avr.
>
> N.B. All patches should go to gcc-patches (as well as a more specific list like libstdc++ when appropriate).
>
> OK for trunk
I've pushed this now - thanks again.
>
>
>
> On Fri, 8 Sept 2023, 10:49 Alexey Lapshin via Libstdc++, <libstdc++@gcc.gnu.org> wrote:
>>
>> Added to CC: jwakely@redhat.com, hp@axis.com
>>
>>
>> On Fri, 2023-09-08 at 12:39 +0400, Alexey Lapshin wrote:
>> > -Werror flag should depend on --enable-werror configure option
>> >
>> > ---
>> > libstdc++-v3/src/libbacktrace/Makefile.am | 2 +-
>> > libstdc++-v3/src/libbacktrace/Makefile.in | 2 +-
>> > 2 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.am b/libstdc++-v3/src/libbacktrace/Makefile.am
>> > index 9abf9dd64a1..27c1ea570e0 100644
>> > --- a/libstdc++-v3/src/libbacktrace/Makefile.am
>> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.am
>> > @@ -45,7 +45,7 @@ libstdc___libbacktrace_la_CPPFLAGS = \
>> > $(BACKTRACE_CPPFLAGS)
>> >
>> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
>> > - -Wcast-qual -Werror
>> > + -Wcast-qual
>> > C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wno-unused-but-set-variable
>> > CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter
>> > AM_CFLAGS = $(C_WARN_FLAGS)
>> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.in b/libstdc++-v3/src/libbacktrace/Makefile.in
>> > index 1c1242d8827..b78c8443751 100644
>> > --- a/libstdc++-v3/src/libbacktrace/Makefile.in
>> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.in
>> > @@ -368,7 +368,7 @@ VTV_CXXFLAGS = @VTV_CXXFLAGS@
>> > VTV_CXXLINKFLAGS = @VTV_CXXLINKFLAGS@
>> > VTV_PCH_CXXFLAGS = @VTV_PCH_CXXFLAGS@
>> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \
>> > - -Wcast-qual -Werror
>> > + -Wcast-qual
>> >
>> > XMLCATALOG = @XMLCATALOG@
>> > XMLLINT = @XMLLINT@
>>
prev parent reply other threads:[~2023-09-08 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 8:39 Alexey Lapshin
2023-09-08 9:48 ` Alexey Lapshin
2023-09-08 10:10 ` Jonathan Wakely
2023-09-08 17:05 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4msJvQVYqrCHVvbG6S19rLUSqerwG_7te1_RJL3Dxrz2Q@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=alexey.lapshin@espressif.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).