public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@adacore.com>
To: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: [PATCH] libstdc++: 60241.cc: tolerate slightly shorter aggregate sleep
Date: Wed, 22 Jun 2022 03:01:43 -0300	[thread overview]
Message-ID: <or4k0db5iw.fsf@lxoliva.fsfla.org> (raw)


On rtems under qemu, the frequently-interrupted nanosleep ends up
sleeping shorter than expected, by a margin of less than 0,3%.

I figured failing the library test over a system (emulator?) bug is
undesirable, so I put in some tolerance for the drift.

Regstrapped on x86_64-linux-gnu, also tested with a cross to
aarch64-rtems6.  Ok to install?

PS: I see nothing wrong with the implementation of clock_nanosleep (used
by nanosleep) on rtems6 that could cause it to wake up too early.  I
suspect some artifact of the emulation environment.


for  libstdc++-v3/ChangeLog

	* testsuite/30_threads/this_thread/60421.cc: Tolerate a
	slightly early wakeup.
---
 .../testsuite/30_threads/this_thread/60421.cc      |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc b/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc
index 12dbeba1cc492..f3a5af453c4ad 100644
--- a/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc
+++ b/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc
@@ -51,9 +51,10 @@ test02()
   std::thread t([&result, &sleeping] {
     auto start = std::chrono::system_clock::now();
     auto time = std::chrono::seconds(3);
+    auto tolerance = std::chrono::milliseconds(10);
     sleeping = true;
     std::this_thread::sleep_for(time);
-    result = std::chrono::system_clock::now() >= (start + time);
+    result = std::chrono::system_clock::now() + tolerance >= (start + time);
     sleeping = false;
   });
   while (!sleeping)


-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

             reply	other threads:[~2022-06-22  6:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  6:01 Alexandre Oliva [this message]
2022-06-22  6:22 ` Sebastian Huber
2022-06-22  8:55   ` Sebastian Huber
2022-06-23  0:15     ` Alexandre Oliva
2022-06-23  0:19     ` Alexandre Oliva
2022-06-23  6:44       ` Sebastian Huber
2022-06-23  7:27         ` Sebastian Huber
2022-06-23 11:33           ` Alexandre Oliva
2022-06-23 11:37             ` Sebastian Huber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=or4k0db5iw.fsf@lxoliva.fsfla.org \
    --to=oliva@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).