Re: [PATCH] libstdc++: testsuite: use -lbsd for net_ts on RTEMS

[Alexandre Oliva <oliva@adacore.com>]

On Jun 23, 2022, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:

> On Thu, 23 Jun 2022, 10:02 Sebastian Huber, <
> sebastian.huber@embedded-brains.de> wrote:

>> On 22/06/2022 07:24, Alexandre Oliva via Gcc-patches wrote:
>> > +    } elseif { [istarget *-*-rtems*] } {
>> > +     # Adding -Wl,--gc-sections would enable a few more tests to
>> > +     # link, but all of them fail at runtime anyway, because the
>> > +     # io_context ctor calls pipe(), which always fails, and thus
>> > +     # the ctor throws a system error.
>> > +     return "$flags -lbsd"
>> 
>> Using -Wl,--gc-sections is mandatory if you want to link against
>> libbsd.a.

Weirdly, it worked for all other testcases.

>> For pipe() support in RTEMS, you currently need the

>> #define CONFIGURE_IMFS_ENABLE_MKFIFO

Thanks, I'll reach out to the person in charge of our rtems
configuration for this project, and suggest enabling it on our end.


> It would also be fine to just xfail the networking tests for rtems.

I was using something like this internally.  Regstrapped on
x86_64-linux-gnu, also tested with a cross to aarch64-rtems6.  Ok to
install?


libstdc++: xfail io_context/pipe users on rtems

From: Alexandre Oliva <oliva@adacore.com>

A handful of tests fail on rtems because pipe() always returns -1, and
the io_context ctor throws a system error when pipe() fails.


for  libstdc++-v3/ChangeLog

	* testsuite/experimental/net/timer/waitable/cons.cc: xfail on
	RTEMS.
	* testsuite/experimental/net/timer/waitable/dest.cc: Likewise.
	* testsuite/experimental/net/timer/waitable/ops.cc: Likewise.
	* testsuite/experimental/net/internet/resolver/ops/lookup.cc:
	Likewise.
	* testsuite/experimental/net/internet/resolver/ops/reverse.cc:
	Likewise.

TN: V617-003
---
 .../net/internet/resolver/ops/lookup.cc            |    1 +
 .../net/internet/resolver/ops/reverse.cc           |    1 +
 .../experimental/net/timer/waitable/cons.cc        |    1 +
 .../experimental/net/timer/waitable/dest.cc        |    1 +
 .../experimental/net/timer/waitable/ops.cc         |    1 +
 5 files changed, 5 insertions(+)

diff --git a/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/lookup.cc b/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/lookup.cc
index eb411dea8369c..7684c21012dfb 100644
--- a/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/lookup.cc
+++ b/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/lookup.cc
@@ -18,6 +18,7 @@
 // { dg-do run { target c++14 } }
 // { dg-require-effective-target net_ts_ip }
 // { dg-add-options net_ts }
+// { dg-xfail-if "io_context requires a working pipe" { *-*-rtems* } }
 
 #include <experimental/internet>
 #include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/reverse.cc b/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/reverse.cc
index 361df2676efc8..3ef51f9ebe848 100644
--- a/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/reverse.cc
+++ b/libstdc++-v3/testsuite/experimental/net/internet/resolver/ops/reverse.cc
@@ -18,6 +18,7 @@
 // { dg-do run { target c++14 } }
 // { dg-require-effective-target net_ts_ip }
 // { dg-add-options net_ts }
+// { dg-xfail-if "io_context requires a working pipe" { *-*-rtems* } }
 
 #include <experimental/internet>
 #include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/experimental/net/timer/waitable/cons.cc b/libstdc++-v3/testsuite/experimental/net/timer/waitable/cons.cc
index 40ae5b965a2b0..4e055eadb20a0 100644
--- a/libstdc++-v3/testsuite/experimental/net/timer/waitable/cons.cc
+++ b/libstdc++-v3/testsuite/experimental/net/timer/waitable/cons.cc
@@ -17,6 +17,7 @@
 
 // { dg-do run { target c++14 } }
 // { dg-add-options libatomic }
+// { dg-xfail-if "io_context requires a working pipe" { *-*-rtems* } }
 
 #include <experimental/timer>
 #include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/experimental/net/timer/waitable/dest.cc b/libstdc++-v3/testsuite/experimental/net/timer/waitable/dest.cc
index f571f4a8d861a..2f2e425fa0b33 100644
--- a/libstdc++-v3/testsuite/experimental/net/timer/waitable/dest.cc
+++ b/libstdc++-v3/testsuite/experimental/net/timer/waitable/dest.cc
@@ -17,6 +17,7 @@
 
 // { dg-do run { target c++14 } }
 // { dg-add-options libatomic }
+// { dg-xfail-if "io_context requires a working pipe" { *-*-rtems* } }
 
 #include <experimental/timer>
 #include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/experimental/net/timer/waitable/ops.cc b/libstdc++-v3/testsuite/experimental/net/timer/waitable/ops.cc
index 97ab629b893a9..a52f3259193c4 100644
--- a/libstdc++-v3/testsuite/experimental/net/timer/waitable/ops.cc
+++ b/libstdc++-v3/testsuite/experimental/net/timer/waitable/ops.cc
@@ -17,6 +17,7 @@
 
 // { dg-do run { target c++14 } }
 // { dg-add-options libatomic }
+// { dg-xfail-if "io_context requires a working pipe" { *-*-rtems* } }
 
 #include <experimental/timer>
 #include <testsuite_hooks.h>


-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>