public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2 ./WHATS_NEW tools/lvremove.c
@ 2006-10-23 11:46 pcaulfield
  0 siblings, 0 replies; only message in thread
From: pcaulfield @ 2006-10-23 11:46 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	pcaulfield@sourceware.org	2006-10-23 11:46:16

Modified files:
	.              : WHATS_NEW 
	tools          : lvremove.c 

Log message:
	Don't allow a node to remove an LV that's exclusively active on anther node.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.476&r2=1.477
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvremove.c.diff?cvsroot=lvm2&r1=1.48&r2=1.49

--- LVM2/WHATS_NEW	2006/10/21 23:18:43	1.476
+++ LVM2/WHATS_NEW	2006/10/23 11:46:15	1.477
@@ -1,5 +1,6 @@
 Version 2.02.13 -
 ===================================
+  Don't allow a node to remove an LV that's exclusively active on anther node.
   Cope if same PV is included more than once in cmdline PE range list.
   Set PV size to current device size if it is found to be zero.
   Add segment parameter to target_present functions.
--- LVM2/tools/lvremove.c	2006/05/09 21:23:51	1.48
+++ LVM2/tools/lvremove.c	2006/10/23 11:46:16	1.49
@@ -75,6 +75,16 @@
 	if (!archive(vg))
 		return ECMD_FAILED;
 
+	/* If the VG is clustered then make sure no-one else is using the LV
+	   we are about to remove */
+	if (vg->status & CLUSTERED) {
+		if (!activate_lv_excl(cmd, lv)) {
+			log_error("Can't get exclusive access to volume \"%s\"",
+				  lv->name);
+			return ECMD_FAILED;
+		}
+	}
+
 	/* FIXME Snapshot commit out of sequence if it fails after here? */
 	if (!deactivate_lv(cmd, lv)) {
 		log_error("Unable to deactivate logical volume \"%s\"",


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-10-23 11:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-23 11:46 LVM2 ./WHATS_NEW tools/lvremove.c pcaulfield

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).