public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata-exporte ... Date: Mon, 07 Jan 2008 20:42:00 -0000 [thread overview] Message-ID: <20080107204258.9766.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2008-01-07 20:42:57 Modified files: . : WHATS_NEW lib/metadata : metadata-exported.h metadata.c tools : reporter.c Log message: Fix a segfault if using pvs with --all argument. (2.02.29) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.751&r2=1.752 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata-exported.h.diff?cvsroot=lvm2&r1=1.29&r2=1.30 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.145&r2=1.146 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/reporter.c.diff?cvsroot=lvm2&r1=1.32&r2=1.33 --- LVM2/WHATS_NEW 2008/01/04 11:48:40 1.751 +++ LVM2/WHATS_NEW 2008/01/07 20:42:56 1.752 @@ -1,5 +1,6 @@ Version 2.02.30 - =================================== + Fix a segfault if using pvs with --all argument. (2.02.29) Update --uuid argument description in man pages. Fix vgreduce PV list processing not to process every PV in the VG. (2.02.29) Extend lvconvert to use polldaemon. --- LVM2/lib/metadata/metadata-exported.h 2007/12/22 02:12:59 1.29 +++ LVM2/lib/metadata/metadata-exported.h 2008/01/07 20:42:57 1.30 @@ -312,6 +312,7 @@ int pv_write(struct cmd_context *cmd, struct physical_volume *pv, struct list *mdas, int64_t label_sector); +int is_pv(pv_t *pv); int is_orphan_vg(const char *vg_name); int is_orphan(pv_t *pv); vg_t *vg_lock_and_read(struct cmd_context *cmd, const char *vg_name, --- LVM2/lib/metadata/metadata.c 2007/12/20 18:55:46 1.145 +++ LVM2/lib/metadata/metadata.c 2008/01/07 20:42:57 1.146 @@ -1832,6 +1832,15 @@ return is_orphan_vg(pv_field(pv, vg_name)); } +/** + * is_pv - Determine whether a pv is a real pv or dummy one + * @pv: handle to device + */ +int is_pv(pv_t *pv) +{ + return (pv_field(pv, vg_name) ? 1 : 0); +} + /* * Returns: * 0 - fail --- LVM2/tools/reporter.c 2007/12/20 16:49:37 1.32 +++ LVM2/tools/reporter.c 2008/01/07 20:42:57 1.33 @@ -91,7 +91,7 @@ int ret = ECMD_PROCESSED; const char *vg_name = NULL; - if (!is_orphan(pv) && !vg) { + if (is_pv(pv) && !is_orphan(pv) && !vg) { vg_name = pv_vg_name(pv); if (!(vg = vg_lock_and_read(cmd, vg_name, (char *)&pv->vgid,
next reply other threads:[~2008-01-07 20:42 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-07 20:42 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-12-01 0:09 jbrassow 2011-10-28 20:12 zkabelac 2011-10-07 14:56 jbrassow 2011-09-14 9:57 zkabelac 2011-09-07 8:34 zkabelac 2011-08-18 19:43 jbrassow 2011-08-18 19:34 jbrassow 2011-03-11 14:56 prajnoha 2011-03-02 20:00 mbroz 2011-02-25 14:02 prajnoha 2010-05-21 14:07 zkabelac 2010-05-21 12:55 zkabelac 2010-05-21 12:52 zkabelac 2010-05-14 15:19 jbrassow 2010-03-16 15:30 agk 2010-03-16 14:37 agk 2009-07-14 2:19 wysochanski 2009-06-05 20:00 mbroz 2009-06-01 14:43 mbroz 2009-02-03 16:19 wysochanski 2008-04-23 14:33 wysochanski 2008-02-13 20:01 meyering 2008-01-18 22:02 agk 2008-01-16 18:15 agk 2007-11-15 2:20 agk 2007-10-12 14:08 wysochanski 2007-09-20 21:39 wysochanski 2007-08-30 20:30 wysochanski 2007-08-21 17:38 wysochanski 2007-07-23 17:27 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080107204258.9766.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).