public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata-exporte ... Date: Tue, 03 Feb 2009 16:19:00 -0000 [thread overview] Message-ID: <20090203161927.12950.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-02-03 16:19:26 Modified files: . : WHATS_NEW lib/metadata : metadata-exported.h metadata.c tools : toollib.c Log message: Rename get_vgs() to get_vgnames() and clarify related error messages. get_vgs() really returns a list of vgnames. In the future we will use get_vgs() to return a list of vg structures, similar to get_pvs(). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1032&r2=1.1033 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata-exported.h.diff?cvsroot=lvm2&r1=1.60&r2=1.61 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.202&r2=1.203 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.141&r2=1.142 --- LVM2/WHATS_NEW 2009/02/02 14:34:24 1.1032 +++ LVM2/WHATS_NEW 2009/02/03 16:19:25 1.1033 @@ -1,5 +1,6 @@ Version 2.02.45 - =================================== + Rename get_vgs() to get_vgnames() and clarify related error messages. Allow clvmd to be built with all cluster managers & select one on cmdline. Mention --with-clvmd=corosync in ./configure. Replace internal vg_check_status() implementation. --- LVM2/lib/metadata/metadata-exported.h 2009/01/27 01:48:47 1.60 +++ LVM2/lib/metadata/metadata-exported.h 2009/02/03 16:19:26 1.61 @@ -370,7 +370,7 @@ struct dm_list *get_pvs(struct cmd_context *cmd); /* Set full_scan to 1 to re-read every (filtered) device label */ -struct dm_list *get_vgs(struct cmd_context *cmd, int full_scan); +struct dm_list *get_vgnames(struct cmd_context *cmd, int full_scan); struct dm_list *get_vgids(struct cmd_context *cmd, int full_scan); int scan_vgs_for_pvs(struct cmd_context *cmd); --- LVM2/lib/metadata/metadata.c 2009/01/27 01:48:47 1.202 +++ LVM2/lib/metadata/metadata.c 2009/02/03 16:19:26 1.203 @@ -2039,8 +2039,8 @@ * allowed to do a full scan here any more. */ // The slow way - full scan required to cope with vgrename - if (!(vgnames = get_vgs(cmd, 2))) { - log_error("vg_read_by_vgid: get_vgs failed"); + if (!(vgnames = get_vgnames(cmd, 2))) { + log_error("vg_read_by_vgid: get_vgnames failed"); return NULL; } @@ -2167,7 +2167,7 @@ } /* May return empty list */ -struct dm_list *get_vgs(struct cmd_context *cmd, int full_scan) +struct dm_list *get_vgnames(struct cmd_context *cmd, int full_scan) { return lvmcache_get_vgnames(cmd, full_scan); } @@ -2201,7 +2201,7 @@ /* Get list of VGs */ if (!(vgids = get_vgids(cmd, 0))) { - log_error("get_pvs: get_vgs failed"); + log_error("get_pvs: get_vgids failed"); return 0; } --- LVM2/tools/toollib.c 2009/01/26 19:01:32 1.141 +++ LVM2/tools/toollib.c 2009/02/03 16:19:26 1.142 @@ -273,7 +273,7 @@ if (!argc || !dm_list_empty(&tags)) { log_verbose("Finding all logical volumes"); - if (!(vgnames = get_vgs(cmd, 0)) || dm_list_empty(vgnames)) { + if (!(vgnames = get_vgnames(cmd, 0)) || dm_list_empty(vgnames)) { log_error("No volume groups found"); return ret_max; } @@ -713,7 +713,7 @@ if (sigint_caught()) return ret_max; } - if (!dm_list_empty(&tags) && (vgnames = get_vgs(cmd, 0)) && + if (!dm_list_empty(&tags) && (vgnames = get_vgnames(cmd, 0)) && !dm_list_empty(vgnames)) { dm_list_iterate_items(sll, vgnames) { if (!lock_vol(cmd, sll->str, lock_type)) {
next reply other threads:[~2009-02-03 16:19 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-02-03 16:19 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-12-01 0:09 jbrassow 2011-10-28 20:12 zkabelac 2011-10-07 14:56 jbrassow 2011-09-14 9:57 zkabelac 2011-09-07 8:34 zkabelac 2011-08-18 19:43 jbrassow 2011-08-18 19:34 jbrassow 2011-03-11 14:56 prajnoha 2011-03-02 20:00 mbroz 2011-02-25 14:02 prajnoha 2010-05-21 14:07 zkabelac 2010-05-21 12:55 zkabelac 2010-05-21 12:52 zkabelac 2010-05-14 15:19 jbrassow 2010-03-16 15:30 agk 2010-03-16 14:37 agk 2009-07-14 2:19 wysochanski 2009-06-05 20:00 mbroz 2009-06-01 14:43 mbroz 2008-04-23 14:33 wysochanski 2008-02-13 20:01 meyering 2008-01-18 22:02 agk 2008-01-16 18:15 agk 2008-01-07 20:42 mbroz 2007-11-15 2:20 agk 2007-10-12 14:08 wysochanski 2007-09-20 21:39 wysochanski 2007-08-30 20:30 wysochanski 2007-08-21 17:38 wysochanski 2007-07-23 17:27 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090203161927.12950.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).