public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/test t-vgsplit-operation.sh
Date: Fri, 21 Mar 2008 21:14:00 -0000	[thread overview]
Message-ID: <20080321211439.6299.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2008-03-21 21:14:39

Modified files:
	test           : t-vgsplit-operation.sh 

Log message:
	Update vgsplit tests to execute twice (existing and new VG as destination).

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-vgsplit-operation.sh.diff?cvsroot=lvm2&r1=1.12&r2=1.13

--- LVM2/test/t-vgsplit-operation.sh	2008/03/04 22:49:00	1.12
+++ LVM2/test/t-vgsplit-operation.sh	2008/03/21 21:14:38	1.13
@@ -23,7 +23,7 @@
   rm -f "$f1" "$f2" "$f3" "$f4"
 }
 
-validate_vg_pvlv_counts_()
+vg_validate_pvlv_counts_()
 {
 	local local_vg=$1
 	local num_pvs=$2
@@ -51,53 +51,83 @@
    lv3=$(this_test_)-test-lv3-$$          &&
    pvcreate $d1 $d2 $d3 $d4'
 
+#
+# vgsplit can be done into a new or existing VG
+#
+for i in new existing
+do
 test_expect_success \
-  'vgsplit correctly splits single linear LV into existing VG' \
+  "vgsplit correctly splits single linear LV into $i VG" \
   'vgcreate $vg1 $d1 $d2 &&
-   vgcreate $vg2 $d3 $d4 &&
+   if [ $i == existing ]; then
+      vgcreate $vg2 $d3 $d4
+   fi &&
    lvcreate -l 4 -n $lv1 $vg1 $d1 &&
    vgchange -an $vg1 &&
-   vgsplit $vg1 $vg2 $d1 &&
-   validate_vg_pvlv_counts_ $vg1 1 0 0 &&
-   validate_vg_pvlv_counts_ $vg2 3 1 0 &&
+   vgsplit --force $vg1 $vg2 $d1 &&
+   vg_validate_pvlv_counts_ $vg1 1 0 0 &&
+   if [ $i == existing ]; then
+      vg_validate_pvlv_counts_ $vg2 3 1 0
+   else
+      vg_validate_pvlv_counts_ $vg2 1 1 0
+   fi &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2 &&
    vgremove -f $vg1'
 
 test_expect_success \
-  'vgsplit correctly splits single striped LV into existing VG' \
+  "vgsplit correctly splits single striped LV into $i VG" \
   'vgcreate $vg1 $d1 $d2 &&
-   vgcreate $vg2 $d3 $d4 &&
+   if [ $i == existing ]; then
+      vgcreate $vg2 $d3 $d4
+   fi &&
    lvcreate -l 4 -i 2 -n $lv1 $vg1 $d1 $d2 &&
    vgchange -an $vg1 &&
-   vgsplit $vg1 $vg2 $d1 $d2 &&
-   validate_vg_pvlv_counts_ $vg2 4 1 0 &&
+   vgsplit --force $vg1 $vg2 $d1 $d2 &&
+   if [ $i == existing ]; then
+     vg_validate_pvlv_counts_ $vg2 4 1 0
+   else
+     vg_validate_pvlv_counts_ $vg2 2 1 0
+   fi &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2'
 
 test_expect_success \
-  'vgsplit correctly splits origin and snapshot LV into existing VG' \
+  "vgsplit correctly splits origin and snapshot LV into $i VG" \
   'vgcreate $vg1 $d1 $d2 &&
-   vgcreate $vg2 $d3 $d4 &&
+   if [ $i == existing ]; then
+     vgcreate $vg2 $d3 $d4
+   fi &&
    lvcreate -l 64 -i 2 -n $lv1 $vg1 $d1 $d2 &&
    lvcreate -l 4 -i 2 -s -n $lv2 $vg1/$lv1 &&
    vgchange -an $vg1 &&
-   vgsplit $vg1 $vg2 $d1 $d2 &&
-   validate_vg_pvlv_counts_ $vg2 4 1 1 &&
+   vgsplit --force $vg1 $vg2 $d1 $d2 &&
+   if [ $i == existing ]; then
+     vg_validate_pvlv_counts_ $vg2 4 1 1
+   else
+     vg_validate_pvlv_counts_ $vg2 2 1 1
+   fi &&
    lvremove -f $vg2/$lv2 &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2'
 
 test_expect_success \
-  'vgsplit correctly splits mirror LV into existing VG' \
+  "vgsplit correctly splits mirror LV into $i VG" \
   'vgcreate $vg1 $d1 $d2 $d3 &&
-   vgcreate $vg2 $d4 &&
+   if [ $i == existing ]; then
+     vgcreate $vg2 $d4
+   fi &&
    lvcreate -l 64 -m1 -n $lv1 $vg1 $d1 $d2 $d3 &&
    vgchange -an $vg1 &&
-   vgsplit $vg1 $vg2 $d1 $d2 $d3 &&
-   validate_vg_pvlv_counts_ $vg2 4 4 0 &&
+   vgsplit --force $vg1 $vg2 $d1 $d2 $d3 &&
+   if [ $i == existing ]; then
+     vg_validate_pvlv_counts_ $vg2 4 4 0
+   else
+     vg_validate_pvlv_counts_ $vg2 3 4 0
+   fi &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2'
+done
 
 test_done
 # Local Variables:


             reply	other threads:[~2008-03-21 21:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21 21:14 wysochanski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-29 16:40 mornfall
2008-09-30 18:29 mornfall
2008-09-30 17:56 mornfall
2008-04-10 18:55 wysochanski
2008-04-09 21:10 wysochanski
2008-03-04 22:49 wysochanski
2008-02-29  0:09 wysochanski
2008-02-28 17:39 wysochanski
2008-02-28 16:48 wysochanski
2008-01-22  3:30 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080321211439.6299.qmail@sourceware.org \
    --to=wysochanski@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).