public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: mornfall@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/test t-vgsplit-operation.sh
Date: Tue, 30 Sep 2008 18:29:00 -0000	[thread overview]
Message-ID: <20080930182910.4544.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall@sourceware.org	2008-09-30 18:29:10

Modified files:
	test           : t-vgsplit-operation.sh 

Log message:
	Fix [ a = b ] usage in t-vgsplit-operation: string comparison is '=', not '=='.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-vgsplit-operation.sh.diff?cvsroot=lvm2&r1=1.22&r2=1.23

--- LVM2/test/t-vgsplit-operation.sh	2008/09/30 17:56:54	1.22
+++ LVM2/test/t-vgsplit-operation.sh	2008/09/30 18:29:10	1.23
@@ -34,18 +34,18 @@
 	do
 COMM "vgsplit correctly splits single linear LV into $i VG ($j args)"
 		vgcreate $vg1 $dev1 $dev2 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		   vgcreate $vg2 $dev3 $dev4
 		fi 
 		lvcreate -l 4 -n $lv1 $vg1 $dev1 
 		vgchange -an $vg1 
-		if [ $j == PV ]; then
+		if [ $j = PV ]; then
 		  vgsplit $vg1 $vg2 $dev1
 		else
 		  vgsplit -n $lv1 $vg1 $vg2
 		fi 
 		vg_validate_pvlv_counts_ $vg1 1 0 0 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		   aux vg_validate_pvlv_counts_ $vg2 3 1 0
 		else
 		   aux vg_validate_pvlv_counts_ $vg2 1 1 0
@@ -56,17 +56,17 @@
 
 COMM "vgsplit correctly splits single striped LV into $i VG ($j args)"
 		vgcreate $vg1 $dev1 $dev2 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		   vgcreate $vg2 $dev3 $dev4
 		fi 
 		lvcreate -l 4 -i 2 -n $lv1 $vg1 $dev1 $dev2 
 		vgchange -an $vg1 
-		if [ $j == PV ]; then
+		if [ $j = PV ]; then
 		  vgsplit $vg1 $vg2 $dev1 $dev2
 		else
 		  vgsplit -n $lv1 $vg1 $vg2
 		fi 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  aux vg_validate_pvlv_counts_ $vg2 4 1 0
 		else
 		  aux vg_validate_pvlv_counts_ $vg2 2 1 0
@@ -76,17 +76,17 @@
 
 COMM "vgsplit correctly splits mirror LV into $i VG ($j args)" 
 		vgcreate $vg1 $dev1 $dev2 $dev3 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  vgcreate $vg2 $dev4
 		fi 
 		lvcreate -l 64 -m1 -n $lv1 $vg1 $dev1 $dev2 $dev3 
 		vgchange -an $vg1 
-		if [ $j == PV ]; then
+		if [ $j = PV ]; then
 		  vgsplit $vg1 $vg2 $dev1 $dev2 $dev3
 		else
 		  vgsplit -n $lv1 $vg1 $vg2
 		fi 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  aux vg_validate_pvlv_counts_ $vg2 4 1 0
 		else
 		  aux vg_validate_pvlv_counts_ $vg2 3 1 0
@@ -96,18 +96,18 @@
 
 COMM "vgsplit correctly splits origin and snapshot LV into $i VG ($j args)" 
 		vgcreate $vg1 $dev1 $dev2 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  vgcreate $vg2 $dev3 $dev4
 		fi 
 		lvcreate -l 64 -i 2 -n $lv1 $vg1 $dev1 $dev2 
 		lvcreate -l 4 -i 2 -s -n $lv2 $vg1/$lv1 
 		vgchange -an $vg1 
-		if [ $j == PV ]; then
+		if [ $j = PV ]; then
 		  vgsplit $vg1 $vg2 $dev1 $dev2
 		else
 		  vgsplit -n $lv1 $vg1 $vg2
 		fi 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  aux vg_validate_pvlv_counts_ $vg2 4 2 1
 		else
 		  aux vg_validate_pvlv_counts_ $vg2 2 2 1
@@ -118,7 +118,7 @@
 
 COMM "vgsplit correctly splits linear LV but not snap+origin LV into $i VG ($j args)" 
 		vgcreate $vg1 $dev1 $dev2 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  vgcreate $vg2 $dev3
 		fi 
 		lvcreate -l 64 -i 2 -n $lv1 $vg1 
@@ -126,12 +126,12 @@
 		vgextend $vg1 $dev4 
 		lvcreate -l 64 -n $lv3 $vg1 $dev4 
 		vgchange -an $vg1 
-		if [ $j == PV ]; then
+		if [ $j = PV ]; then
 		  vgsplit $vg1 $vg2 $dev4
 		else
 		  vgsplit -n $lv3 $vg1 $vg2
 		fi 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  aux vg_validate_pvlv_counts_ $vg2 2 1 0
 		  aux vg_validate_pvlv_counts_ $vg1 2 2 1
 		else
@@ -146,7 +146,7 @@
 
 COMM "vgsplit correctly splits linear LV but not mirror LV into $i VG ($j args)" 
 		vgcreate $vg1 $dev1 $dev2 $dev3 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  vgcreate $vg2 $dev5
 		fi 
 		lvcreate -l 64 -m1 -n $lv1 $vg1 $dev1 $dev2 $dev3 
@@ -156,12 +156,12 @@
 		vgs
 		lvs 
 		pvs
-		if [ $j == PV ]; then
+		if [ $j = PV ]; then
 		  vgsplit $vg1 $vg2 $dev4
 		else
 		  vgsplit -n $lv2 $vg1 $vg2
 		fi 
-		if [ $i == existing ]; then
+		if [ $i = existing ]; then
 		  aux vg_validate_pvlv_counts_ $vg1 3 1 0
 		  aux vg_validate_pvlv_counts_ $vg2 2 1 0
 		else


             reply	other threads:[~2008-09-30 18:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30 18:29 mornfall [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-29 16:40 mornfall
2008-09-30 17:56 mornfall
2008-04-10 18:55 wysochanski
2008-04-09 21:10 wysochanski
2008-03-21 21:14 wysochanski
2008-03-04 22:49 wysochanski
2008-02-29  0:09 wysochanski
2008-02-28 17:39 wysochanski
2008-02-28 16:48 wysochanski
2008-01-22  3:30 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080930182910.4544.qmail@sourceware.org \
    --to=mornfall@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).