public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW tools/vgsplit.c
Date: Wed, 02 Apr 2008 13:08:00 -0000	[thread overview]
Message-ID: <20080402130849.29631.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2008-04-02 13:08:49

Modified files:
	.              : WHATS_NEW 
	tools          : vgsplit.c 

Log message:
	Suppress "Volume group not found" message when vgsplit of new VG.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.815&r2=1.816
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.52&r2=1.53

--- LVM2/WHATS_NEW	2008/04/01 22:40:12	1.815
+++ LVM2/WHATS_NEW	2008/04/02 13:08:49	1.816
@@ -1,5 +1,7 @@
 Version 2.02.34 -
 ===================================
+  Suppress excess messages when vgsplit into a new vg.
+  Suppress duplicate message when lvresize fails because of invalid vgname.
   Cache VG metadata internally while VG lock is held.
   Fix redundant lvresize message if vg doesn't exist.
   Fix another allocation bug with clvmd and large node IDs.
--- LVM2/tools/vgsplit.c	2008/03/26 17:26:32	1.52
+++ LVM2/tools/vgsplit.c	2008/04/02 13:08:49	1.53
@@ -220,6 +220,7 @@
 	int opt;
 	int active;
 	int existing_vg;
+	int old_suppress;
 	struct pv_list *pvl;
 
 	if (argc < 3) {
@@ -253,9 +254,11 @@
 	}
 
 	log_verbose("Checking for new volume group \"%s\"", vg_name_to);
+	old_suppress = log_suppress(2);
 	if ((vg_to = vg_lock_and_read(cmd, vg_name_to, NULL,
 				      LCK_VG_WRITE | LCK_NONBLOCK,
 				      0, 0))) {
+		log_suppress(old_suppress);
 		existing_vg = 1;
 		if (new_vg_option_specified(cmd)) {
 			log_error("Volume group \"%s\" exists, but new VG "
@@ -265,6 +268,7 @@
 		if (!vgs_are_compatible(cmd, vg_from,vg_to))
 			goto error;
 	} else {
+		log_suppress(old_suppress);
 		existing_vg = 0;
 
 		/* Set metadata format of original VG */


             reply	other threads:[~2008-04-02 13:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02 13:08 wysochanski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-08 21:47 wysochanski
2008-04-08 21:38 wysochanski
2008-04-02 19:30 wysochanski
2007-06-28 17:59 mbroz
2007-05-15 13:01 mbroz
2006-10-13 13:22 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080402130849.29631.qmail@sourceware.org \
    --to=wysochanski@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).