public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/vgsplit.c Date: Tue, 15 May 2007 13:01:00 -0000 [thread overview] Message-ID: <20070515130142.7227.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2007-05-15 13:01:41 Modified files: . : WHATS_NEW tools : vgsplit.c Log message: Fix and clarify vgsplit error messages. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.616&r2=1.617 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.24&r2=1.25 --- LVM2/WHATS_NEW 2007/05/14 11:27:33 1.616 +++ LVM2/WHATS_NEW 2007/05/15 13:01:40 1.617 @@ -1,5 +1,6 @@ Version 2.02.26 - ================================= + Fix and clarify vgsplit error messages. Fix a segfault if a device has no target (no table) Add some more debuglogs to clvmd startup. Misc clvmd cleanups --- LVM2/tools/vgsplit.c 2007/03/23 12:43:17 1.24 +++ LVM2/tools/vgsplit.c 2007/05/15 13:01:41 1.25 @@ -145,13 +145,16 @@ list_iterate_items(seg, &lv->segments) { cow_from = _lv_is_in_vg(vg_from, seg->cow); origin_from = _lv_is_in_vg(vg_from, seg->origin); + + if (cow_from && origin_from) + continue; + if ((!cow_from && origin_from) || + (cow_from && !origin_from)) { + log_error("Can't split snapshot %s between" + " two Volume Groups", seg->cow->name); + return 0; + } } - if (cow_from && origin_from) - continue; - if ((!cow_from && origin_from) || (cow_from && !origin_from)) { - log_error("Snapshot %s split", seg->cow->name); - return 0; - } /* Move this snapshot */ list_del(lvh); @@ -190,7 +193,8 @@ if ((seg_in && seg_in < seg->area_count) || (seg_in && seg->log_lv && !log_in) || (!seg_in && seg->log_lv && log_in)) { - log_error("Mirror %s split", lv->name); + log_error("Can't split mirror %s between " + "two Volume Groups", lv->name); return 0; }
next reply other threads:[~2007-05-15 13:01 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-05-15 13:01 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2008-04-08 21:47 wysochanski 2008-04-08 21:38 wysochanski 2008-04-02 19:30 wysochanski 2008-04-02 13:08 wysochanski 2007-06-28 17:59 mbroz 2006-10-13 13:22 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070515130142.7227.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).