public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/test lvm-utils.sh Date: Wed, 25 Jun 2008 16:51:00 -0000 [thread overview] Message-ID: <20080625165127.15553.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2008-06-25 16:51:26 Modified files: test : lvm-utils.sh Log message: Test script cleanup. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/lvm-utils.sh.diff?cvsroot=lvm2&r1=1.12&r2=1.13 --- LVM2/test/lvm-utils.sh 2008/06/06 13:48:57 1.12 +++ LVM2/test/lvm-utils.sh 2008/06/25 16:51:26 1.13 @@ -52,38 +52,64 @@ compare_vg_field_() { + local vg1=$1; + local vg2=$2; + local field=$3; + local val1; + local val2; + + val1=$(vgs --noheadings -o $field $vg1) + val2=$(vgs --noheadings -o $field $vg2) if test "$verbose" = "t" then - echo "compare_vg_field_ VG1: `vgs --noheadings -o $3 $1` VG2: `vgs --noheadings -o $3 $2`" + echo "compare_vg_field_ VG1: $val1 VG2: $val2" fi - return $(test $(vgs --noheadings -o $3 $1) == $(vgs --noheadings -o $3 $2) ) + return $(test $val1 == $val2 ) } check_vg_field_() { + local vg=$1; + local field=$2; + local expected=$3; + local actual; + + actual=$(vgs --noheadings -o $field $vg) if test "$verbose" = "t" then - echo "check_vg_field_ VG=$1, field=$2, actual=`vgs --noheadings -o $2 $1`, expected=$3" + echo "check_vg_field_ VG=$vg, field=$field, actual=$actual, expected=$expected" fi - return $(test $(vgs --noheadings -o $2 $1) == $3) + return $(test $actual == $expected) } check_pv_field_() { + local pv=$1; + local field=$2; + local expected=$3; + local actual; + + actual=$(pvs --noheadings -o $field $pv) if test "$verbose" = "t" then - echo "check_pv_field_ PV=$1, field=$2, actual=`pvs --noheadings -o $2 $1`, expected=$3" + echo "check_pv_field_ PV=$pv, field=$field, actual=$actual, expected=$expected" fi - return $(test $(pvs --noheadings -o $2 $1) == $3) + return $(test $actual == $expected) } check_lv_field_() { + local lv=$1; + local field=$2; + local expected=$3; + local actual; + + actual=$(lvs --noheadings -o $field $lv) if test "$verbose" = "t" then - echo "check_lv_field_ LV=$1, field=$2, actual=`lvs --noheadings -o $2 $1`, expected=$3" + echo "check_lv_field_ LV=$lv, field=$field, actual=$actual, expected=$expected" fi - return $(test $(lvs --noheadings -o $2 $1) == $3) + return $(test $actual == $expected) } vg_validate_pvlv_counts_()
next reply other threads:[~2008-06-25 16:51 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-06-25 16:51 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-03-26 13:21 zkabelac 2010-03-25 12:17 agk 2010-03-25 11:57 agk 2009-01-10 12:19 mornfall 2008-08-21 14:33 wysochanski 2008-06-06 13:48 meyering 2008-04-23 13:02 wysochanski 2008-03-28 18:02 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080625165127.15553.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).