public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/test lvm-utils.sh
Date: Thu, 21 Aug 2008 14:33:00 -0000	[thread overview]
Message-ID: <20080821143349.14478.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2008-08-21 14:33:48

Modified files:
	test           : lvm-utils.sh 

Log message:
	Fix symbolic link creation in test infrastructure.
	
	Original code would create "*.so" symbolic links if there were no actual
	files ending in "so".  The second iteration would then cause an error
	in the test logs.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/lvm-utils.sh.diff?cvsroot=lvm2&r1=1.14&r2=1.15

--- LVM2/test/lvm-utils.sh	2008/08/05 11:39:54	1.14
+++ LVM2/test/lvm-utils.sh	2008/08/21 14:33:48	1.15
@@ -152,8 +152,16 @@
   for i in 0 1 2 3 4 5 6 7; do
     mknod $G_root_/dev/loop$i b 7 $i
   done
-  ln -s $abs_top_builddir/dmeventd/mirror/*.so $G_root_/lib
-  ln -s $abs_top_builddir/dmeventd/snapshot/*.so $G_root_/lib
+  for i in $abs_top_builddir/dmeventd/mirror/*.so $abs_top_builddir/dmeventd/snapshot/*.so
+  do
+    # NOTE: This check is necessary because the loop above will give us the value
+    # "$abs_top_builddir/dmeventd/mirror/*.so" if no files ending in 'so' exist.
+    # This is the best way I could quickly determine to skip over this bogus value.
+    if [ -f $i ]; then
+      echo Setting up symlink from $i to $G_root_/lib
+      ln -s $i $G_root_/lib
+    fi
+  done
   cat > $G_root_/etc/lvm.conf <<-EOF
   devices {
     dir = "$G_dev_"


             reply	other threads:[~2008-08-21 14:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 14:33 wysochanski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-26 13:21 zkabelac
2010-03-25 12:17 agk
2010-03-25 11:57 agk
2009-01-10 12:19 mornfall
2008-06-25 16:51 wysochanski
2008-06-06 13:48 meyering
2008-04-23 13:02 wysochanski
2008-03-28 18:02 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080821143349.14478.qmail@sourceware.org \
    --to=wysochanski@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).