LVM2/tools pvcreate.c pvremove.c

LVM2/tools pvcreate.c pvremove.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2008-07-24 15:25:10

Modified files:
	tools          : pvcreate.c pvremove.c 

Log message:
	reinstate lost FIXME
	- only if kernel gives the info, not to be worked out in userspace
	- with lvm.conf option to enable/disable the check

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvcreate.c.diff?cvsroot=lvm2&r1=1.67&r2=1.68
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.22&r2=1.23

--- LVM2/tools/pvcreate.c	2008/07/23 19:46:33	1.67
+++ LVM2/tools/pvcreate.c	2008/07/24 15:25:09	1.68
@@ -37,6 +37,8 @@
 	struct device *dev;
 	uint64_t md_superblock;
 
+	/* FIXME Check partition type is LVM unless --force is given */
+
 	/* Is there a pv here already? */
 	/* FIXME Use partial mode here? */
 	pv = pv_read(cmd, name, NULL, NULL, 0);
--- LVM2/tools/pvremove.c	2008/07/23 19:46:33	1.22
+++ LVM2/tools/pvremove.c	2008/07/24 15:25:09	1.23
@@ -26,6 +26,8 @@
 {
 	struct physical_volume *pv;
 
+	/* FIXME Check partition type is LVM unless --force is given */
+
 	/* Is there a pv here already? */
 	/* If not, this is an error unless you used -f. */
 	if (!(pv = pv_read(cmd, name, NULL, NULL, 1))) {

LVM2/tools pvcreate.c pvremove.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2007-11-22 01:25:06

Modified files:
	tools          : pvcreate.c pvremove.c 

Log message:
	FIXMEs for case where dm itself has device open

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvcreate.c.diff?cvsroot=lvm2&r1=1.57&r2=1.58
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.20&r2=1.21

--- LVM2/tools/pvcreate.c	2007/11/14 00:08:25	1.57
+++ LVM2/tools/pvcreate.c	2007/11/22 01:25:06	1.58
@@ -86,6 +86,7 @@
 	}
 
 	if (!dev_test_excl(dev)) {
+		/* FIXME Detect whether device-mapper itself is still using it */
 		log_error("Can't open %s exclusively.  Mounted filesystem?",
 			  name);
 		return 0;
--- LVM2/tools/pvremove.c	2007/11/02 20:40:05	1.20
+++ LVM2/tools/pvremove.c	2007/11/22 01:25:06	1.21
@@ -93,6 +93,7 @@
 	}
 
 	if (!dev_test_excl(dev)) {
+		/* FIXME Detect whether device-mapper is still using the device */
 		log_error("Can't open %s exclusively - not removing. "
 			  "Mounted filesystem?", dev_name(dev));
 		goto error;