public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/tools vgcfgrestore.c
@ 2009-07-10 20:10 wysochanski
0 siblings, 0 replies; only message in thread
From: wysochanski @ 2009-07-10 20:10 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2009-07-10 20:10:18
Modified files:
tools : vgcfgrestore.c
Log message:
Change lock ordering of vgcfgrestore to be consistent with other tools.
Orphan lock is now obtained second and released first, and all tools
are consistent in this regard.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgcfgrestore.c.diff?cvsroot=lvm2&r1=1.19&r2=1.20
--- LVM2/tools/vgcfgrestore.c 2009/05/13 13:02:55 1.19
+++ LVM2/tools/vgcfgrestore.c 2009/07/10 20:10:18 1.20
@@ -43,17 +43,17 @@
return ECMD_PROCESSED;
}
- if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
- log_error("Unable to lock orphans");
- return ECMD_FAILED;
- }
-
if (!lock_vol(cmd, vg_name, LCK_VG_WRITE)) {
log_error("Unable to lock volume group %s", vg_name);
unlock_vg(cmd, VG_ORPHANS);
return ECMD_FAILED;
}
+ if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
+ log_error("Unable to lock orphans");
+ return ECMD_FAILED;
+ }
+
if (!(arg_count(cmd, file_ARG) ?
backup_restore_from_file(cmd, vg_name,
arg_str_value(cmd, file_ARG, "")) :
@@ -66,7 +66,7 @@
log_print("Restored volume group %s", vg_name);
- unlock_vg(cmd, vg_name);
unlock_vg(cmd, VG_ORPHANS);
+ unlock_vg(cmd, vg_name);
return ECMD_PROCESSED;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-10 20:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-10 20:10 LVM2/tools vgcfgrestore.c wysochanski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).