public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/activate fs.c Date: Tue, 04 Aug 2009 21:44:00 -0000 [thread overview] Message-ID: <20090804214439.28008.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2009-08-04 21:44:27 Modified files: lib/activate : fs.c Log message: detect udev mk_link problems Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/fs.c.diff?cvsroot=lvm2&r1=1.45&r2=1.46 --- LVM2/lib/activate/fs.c 2009/08/03 18:31:53 1.45 +++ LVM2/lib/activate/fs.c 2009/08/04 21:44:20 1.46 @@ -107,7 +107,7 @@ { char lv_path[PATH_MAX], link_path[PATH_MAX], lvm1_group_path[PATH_MAX]; char vg_path[PATH_MAX]; - struct stat buf; + struct stat buf, buf_lp; if (dm_snprintf(vg_path, sizeof(vg_path), "%s%s", dev_dir, vg_name) == -1) { @@ -161,12 +161,34 @@ return 0; } + if (dm_udev_get_sync_support()) { + /* Check udev created the correct link. */ + if (!stat(link_path, &buf_lp) && + !stat(lv_path, &buf)) { + if (buf_lp.st_rdev == buf.st_rdev) + return 1; + else + log_warn("Symlink %s that should have been " + "created by udev does not have " + "correct target. Falling back to " + "direct link creation", lv_path); + } else + log_warn("Symlink %s that should have been " + "created by udev could not be checked " + "for its correctness. Falling back to " + "direct link creation.", lv_path); + + } + log_very_verbose("Removing %s", lv_path); if (unlink(lv_path) < 0) { log_sys_error("unlink", lv_path); return 0; } - } + } else if (dm_udev_get_sync_support()) + log_warn("The link should had been created by udev " + "but it was not found. Falling back to " + "direct link creation.", lv_path); log_very_verbose("Linking %s -> %s", lv_path, link_path); if (symlink(link_path, lv_path) < 0) {
next reply other threads:[~2009-08-04 21:44 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-08-04 21:44 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-12 20:17 agk 2009-08-05 9:12 prajnoha 2009-08-03 18:31 agk 2004-04-14 18:10 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090804214439.28008.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).